1116901 - Don't reuse parent review for dependent bugs

Status: RESOLVED WORKSFORME

(MozReview Graveyard :: General, defect)

Description

[Martin Thomson [:mt:]]

https://reviewboard.mozilla.org/r/1789/ was created as a parent review for one bug.  That is still in progress, but I'm working on a dependent bug.  Unfortunately, whatever means is being used to detect an existing review caused this review request to be updated, rather than creating a new one.

The very newest bug in a chain should be used as the basis of determining which bug is being reviewed.  If there are multiple bug numbers, then commits for those should not be part of the same parent review.  I think that the easiest thing to do is to avoid creating review requests for commits that don't have a matching bug number.

Comment 1

[Gregory Szorc [:gps]]

FWIW https://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/review-requests.html#review-identifiers documents how the review id / parent review is chosen.

Improving the interaction between multiple bugs / reviews is on the roadmap. Look for major improvements by the end of Q1.

Comment 2

[Martin Thomson [:mt:]]

Indeed, though I'm looking for --new-reviewid or something like that.  As it stands, I can't push that code to reviewboard without some serious breakage.

Comment 3

[Gregory Szorc [:gps]]

You can do `hg push --reviewid <bug number>` today to select an explicit review identifier.

Comment 5

[Mark Côté [:mcote]]

smacleod says this was fixed so that you can specify any single or range of commits.  If so, when was this resolved (as part of what bug)?

Comment 6

[Gregory Szorc [:gps]]

Support for ranges via `hg push -r <revset>` has been supported since launch IIRC. Bug 1097213 landed support for `hg push -c <rev>` to support pushing a single changeset for review.

This is all documented at https://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/review-requests.html

Comment 7

[Mark Côté [:mcote]]

Eventually we'll also be supporting multiple bugs in a single push.  I'm going to resolve this as WORKSFORME given comment 3 and comment; feel free to reopen if this still doesn't meet your needs.