Closed
Bug 1116906
Opened 10 years ago
Closed 10 years ago
Move AlreadyAddRefed.h to MFBT
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.00 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8543120 -
Flags: review?(nfroyd)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8543120 [details] [diff] [review]
Move AlreadyAddRefed.h to MFBT
Review of attachment 8543120 [details] [diff] [review]:
-----------------------------------------------------------------
This patch is fine as far as it goes, but if this is going into MFBT, the comments in AlreadyAddRefed.h need some cleanup:
- Need to explain why already_AddRefed isn't in mozilla::
- Need to explain where these weird nsRefPtr/nsCOMPtr classes come from
- Maybe partially address the above by rewriting things to refer to generic ref-counted smart pointer classes where possible (e.g. the class comment could be "already_AddRefed cooperaters (sic) with refcounted smart pointers to enable you to assign...")
- The comment for downcast() needs to ditch the bit about dont_AddRef, since that's XPCOMish
Attachment #8543120 -
Flags: review?(nfroyd) → feedback+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8543120 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8544068 -
Flags: review?(nfroyd)
|
|
||
Updated•10 years ago
|
Attachment #8544068 -
Flags: review?(nfroyd) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•