Move AlreadyAddRefed.h to MFBT

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8543120 [details] [diff] [review]
Move AlreadyAddRefed.h to MFBT
Attachment #8543120 - Flags: review?(nfroyd)
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1115033
Comment on attachment 8543120 [details] [diff] [review]
Move AlreadyAddRefed.h to MFBT

Review of attachment 8543120 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is fine as far as it goes, but if this is going into MFBT, the comments in AlreadyAddRefed.h need some cleanup:

- Need to explain why already_AddRefed isn't in mozilla::
- Need to explain where these weird nsRefPtr/nsCOMPtr classes come from
- Maybe partially address the above by rewriting things to refer to generic ref-counted smart pointer classes where possible (e.g. the class comment could be "already_AddRefed cooperaters (sic) with refcounted smart pointers to enable you to assign...")
- The comment for downcast() needs to ditch the bit about dont_AddRef, since that's XPCOMish
Attachment #8543120 - Flags: review?(nfroyd) → feedback+
(Assignee)

Updated

4 years ago
Attachment #8543120 - Attachment is obsolete: true
(Assignee)

Comment 3

4 years ago
Created attachment 8544068 [details] [diff] [review]
Move AlreadyAddRefed.h to MFBT
Attachment #8544068 - Flags: review?(nfroyd)
Attachment #8544068 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/a194a9a118f1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.