1116959 - Removing search terms blanks out results list in address book quick search and contacts side bar search

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

STR

1 in AB quicksearch or contacts side bar, of an AB having contacts "John Doe" and "Jane Doe", search for "John"
2 Remove search terms

Actual result
after 1), correctly showing matching contacts ("John Doe")
after 2), wrongly showing no results at all (blank results pane)

Expected result
After clearing search filter terms, all contacts of respective AB must be shown immediately("John Doe" and "Jane Doe")

For all practical UX purposes, this breaks the main AB quick search and contacts side bar entirely because we can't expect users to click back and forth between ABs each time after clearing search terms -> critical

I think this is pretty new -> regression.
I'm quite sure this was still working some weeks ago, or even days.
Seen on 37.0a1 (2014-12-30)/ WinXP.

Comment 1

[Thomas D. (:thomas8)]

If anyone else sees this, pls confirm

Comment 2

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

Even if there are no search terms (blank search box),
the queryURI is being formed and hence, SetAbView isn't
able to display all the cards from the selected AB.

Thanks.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8543153 [details] [diff] [review]
Patch v1

Review of attachment 8543153 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx Suyash! r=mkmelin

Comment 4

[Suyash Agarwal (:sshagarwal)]

Thanks.

Comment 5

[Thomas D. (:thomas8)]

I believe this bug should have a test in the test suite, it should never have occured in the first place.

Comment 6

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/2944600ee1ef

Comment 7

[Richard Marti (:Paenglab)]

Wrong commit above.

http://hg.mozilla.org/comm-central/rev/0da65c550324