Closed Bug 1116978 Opened 5 years ago Closed 3 years ago

[Message] After sending a message from new compose page, compose area should stay focused

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: steveck, Assigned: anirudhgp)

References

Details

(Whiteboard: [lang=js][sms-papercuts])

Attachments

(2 files)

After Bug #1033334 landed, we could keep the keyboard focused on after tapping send button to easily send another message. However, sending a message from new compose page will still dismiss the keyboad while switching to threa view. We should still keep the keyboard on for this scenario in order to have better use experience. And we might need integration test to verify focus status in this case.
No longer depends on: 1033334
Blocks: 1033334
No longer blocks: 1033334
Depends on: 1033334
I'd like to work on this bug! Any pointers as to how I can solve this?
Hi Steve,

Assigning it to anirudh as he likes to work on it.

Thank you.
Assignee: nobody → anirudh.gp
Status: NEW → ASSIGNED
Assign any mentor to this bug.
ni? julien
Flags: needinfo?(felash)
Where does the code for this lie in?
Because we're switching panel, we can try to simply "focusComposer: true" as argument to Navigation.toPanel (see [1] for an example, and [2] for where it's actually processed).

This would happen here: [3]

[1] https://github.com/mozilla-b2g/gaia/blob/c969ba09b4ce1dc8e424889205720d7df0cc1012/apps/sms/js/activity_handler.js#L280-L283
[2] https://github.com/mozilla-b2g/gaia/blob/b1d5b21f6748f97925f60ab63b446db9230a1533/apps/sms/js/thread_ui.js#L611-L613
[3] https://github.com/mozilla-b2g/gaia/blob/b1d5b21f6748f97925f60ab63b446db9230a1533/apps/sms/js/thread_ui.js#L876

Hope this helps !
Flags: needinfo?(felash)
Yeah that makes sense! Thanks Julien.
Hi Anirudh
Instead of creating new patch(pull request) you could have work on same patch  and later squash the commits into one.
Ok I'll do that from now. Thanks rishav !
Duplicate of this bug: 1138714
Mass closing of Gaia::SMS bugs. End of an era :(
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.