MSVC2012 bustage - security\pkix\include\pkix/Input.h(127) : error C2059: syntax error : ';'

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: briansmith)

Tracking

({regression})

Trunk
mozilla37
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Looks like we might have needed some of those workarounds for MSVC2012 as well (which is still a supported compiler).

security\pkix\include\pkix/Input.h(127) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(127) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(294) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(294) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(323) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(323) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(324) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(324) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(83) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(83) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(151) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(151) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(212) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(212) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(213) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(213) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(327) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(327) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(328) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(328) : error C2238: unexpected token(s) preceding ';'
Flags: needinfo?(brian)

Comment 1

4 years ago
Is there any reason that we don't have build servers that at least test compile on VS2012? These bustages occur constantly, and make it really hard for those of us who routinely do development on VS2012. I can't switch to VS2013 because compiles of older version do not work on VS2013, so VS2012 is required to use a single machine for multiple versions of gecko.
(In reply to Kent James (:rkent) from comment #1)
> Is there any reason that we don't have build servers that at least test
> compile on VS2012? These bustages occur constantly, and make it really hard
> for those of us who routinely do development on VS2012.

It isn't reasonable to have MSVC2012 be a supported compiler without MSVC2012 builds on tryserver. Let's just solve this problem by dropping MSCV2012 support.

> I can't switch to
> VS2013 because compiles of older version do not work on VS2013, so VS2012 is
> required to use a single machine for multiple versions of gecko.

It shouldn't be a goal to support building different versions of Firefox with the same compiler. You should be able to install VS2012 and VS2013 side-by-side.
Flags: needinfo?(brian)
Assignee: nobody → brian
Keywords: regression
Target Milestone: --- → mozilla37
Created attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Kent, please review this patch and make sure it fixes the VS2012 build issue you are encountering. Thanks!
Attachment #8543367 - Flags: review?(kent)

Comment 4

4 years ago
Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Yes this compiled successfully on my VS 2012 instance. This is Thunderbird, not Firefox. This is feedback, not a review, since I did not actually examine the code.
Attachment #8543367 - Flags: review?(kent) → feedback+
(Reporter)

Comment 5

4 years ago
Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Works for Firefox too. Thanks for the quick patch!
Attachment #8543367 - Flags: feedback+
Attachment #8543367 - Flags: review?(ehsan)

Comment 6

4 years ago
Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Review of attachment 8543367 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Brian, and sorry that you had to go through this pain... :/
Attachment #8543367 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6b9c81a8c081
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Depends on: 1118122
You need to log in before you can comment on or make changes to this bug.