1117003 - MSVC2012 bustage - security\pkix\include\pkix/Input.h(127) : error C2059: syntax error : ';'

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Looks like we might have needed some of those workarounds for MSVC2012 as well (which is still a supported compiler).

security\pkix\include\pkix/Input.h(127) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(127) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(294) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(294) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(323) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(323) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/Input.h(324) : error C2059: syntax error : ';'
security\pkix\include\pkix/Input.h(324) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(83) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(83) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(151) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(151) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(212) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(212) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(213) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(213) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(327) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(327) : error C2238: unexpected token(s) preceding ';'
security\pkix\include\pkix/pkixtypes.h(328) : error C2059: syntax error : ';'
security\pkix\include\pkix/pkixtypes.h(328) : error C2238: unexpected token(s) preceding ';'

Comment 1

[Kent James (:rkent)]

Is there any reason that we don't have build servers that at least test compile on VS2012? These bustages occur constantly, and make it really hard for those of us who routinely do development on VS2012. I can't switch to VS2013 because compiles of older version do not work on VS2013, so VS2012 is required to use a single machine for multiple versions of gecko.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Kent James (:rkent) from comment #1)
> Is there any reason that we don't have build servers that at least test
> compile on VS2012? These bustages occur constantly, and make it really hard
> for those of us who routinely do development on VS2012.

It isn't reasonable to have MSVC2012 be a supported compiler without MSVC2012 builds on tryserver. Let's just solve this problem by dropping MSCV2012 support.

> I can't switch to
> VS2013 because compiles of older version do not work on VS2013, so VS2012 is
> required to use a single machine for multiple versions of gecko.

It shouldn't be a goal to support building different versions of Firefox with the same compiler. You should be able to install VS2012 and VS2013 side-by-side.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Back out the use of "= delete"

Kent, please review this patch and make sure it fixes the VS2012 build issue you are encountering. Thanks!

Comment 4

[Kent James (:rkent)]

Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Yes this compiled successfully on my VS 2012 instance. This is Thunderbird, not Firefox. This is feedback, not a review, since I did not actually examine the code.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Works for Firefox too. Thanks for the quick patch!

Comment 6

[(no longer active)]

Comment on attachment 8543367 [details] [diff] [review]
Back out the use of "= delete"

Review of attachment 8543367 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Brian, and sorry that you had to go through this pain... :/

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b9c81a8c081

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6b9c81a8c081