1117018 - Duplicated string definitions between contacts.properties and dialer.properties

Status: RESOLVED DUPLICATE of bug 1098673

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

There are two string definitions that are defined both in contacts.properties and dialer.properties.

First is "contacts":
 - https://github.com/mozilla-b2g/gaia/blob/698e6e8a098cc060b26cd6f25171633c4c7e739d/apps/communications/contacts/locales/contacts.en-US.properties#L10
 - https://github.com/mozilla-b2g/gaia/blob/698e6e8a098cc060b26cd6f25171633c4c7e739d/apps/communications/dialer/locales/dialer.en-US.properties#L27

Second is "makeCall":
 - https://github.com/mozilla-b2g/gaia/blob/698e6e8a098cc060b26cd6f25171633c4c7e739d/apps/communications/dialer/locales/dialer.en-US.properties#L45
 - https://github.com/mozilla-b2g/gaia/blob/698e6e8a098cc060b26cd6f25171633c4c7e739d/apps/communications/contacts/locales/contacts.en-US.properties#L77

There are others in communications, which happen to have the same value, but they are redundant and colliding:
 - selectAll
 - deselectAll (3 different files)
 - update
 - search-contact (facebook.properties and contacts.properties)
 - noResults
 - messageCanceling
 - facebook (import_contacts.properties and facebook.properties)
 - curtainCancel
 - close (4 different files)
 - ok
 - contacts
 - delete
 - edit
 - makeCall
 - merge
 - selectAll
 - today
 - yesterday
 - call

The mostly collide in dialer/index.html because it loads all of them, but I would expect it to be a potential collision area for more.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

One comment is that in the future we may want to forbid redundant string definitions within a context.

We will have to fix cases like that and start throwing at build time.