Closed Bug 1117031 Opened 5 years ago Closed 5 years ago

Turn off unused argument warnings for clang-cl

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8543216 - Flags: review?(mh+mozilla)
Assignee: nobody → ehsan
Blocks: winclang
Comment on attachment 8543216 [details] [diff] [review]
Turn off unused argument warnings for clang-cl

Review of attachment 8543216 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1246,5 @@
>  
>  dnl ========================================================
>  dnl Suppress Clang Argument Warnings
>  dnl ========================================================
> +if test -n "${CLANG_CC}${CLANG_CL}"; then

Would it make sense to set CLANG_CC and CLANG_CXX for CLANG_CL builds instead? There's at least one place that would need a change as a consequence (the one that sets various defaults for windows flags), but I wonder if the other places where CLANG_CC and CLANG_CXX are tested are not equally relevant to clang-cl builds. Feel free to investigate this separately.
Attachment #8543216 - Flags: review?(mh+mozilla) → review+
I think keeping CLANG_CL and CLANG_CC/CLANG_CXX separate is the right thing to do in the long run, since there is a ton of stuff different between the toolchains (for example, most driver arguments are different, clang-cl only recognizes a tiny subset of clang/clang++ arguments).  I'm almost convinced that this way we'd get most of the stuff right by default.
https://hg.mozilla.org/mozilla-central/rev/655ef5ce2032
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.