Closed Bug 1117036 Opened 8 years ago Closed 8 years ago

Make it possible to optionally mark functions defined by MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME as MOZ_OVERRIDE

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Make it possible to optionally mark functions defined by MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME as MOZ_OVERRIDE
1.39 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
Comment on attachment 8543219 [details] [diff] [review]
Make it possible to optionally mark functions defined by MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME as MOZ_OVERRIDE

Review of attachment 8543219 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/RefPtr.h
@@ +160,5 @@
>                                 MozRefCountType>::Type mRefCnt;
>  };
>  
>  #ifdef MOZ_REFCOUNTED_LEAK_CHECKING
> +#define MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(T, ...) \

Some comment here about what's appropriate in the varargs would be appreciated, similar to what you have for the XPCOM refcounting macros.
Attachment #8543219 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/58f7805a959f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.