Make it possible to optionally mark functions defined by MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME as MOZ_OVERRIDE

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8543219 [details] [diff] [review]
Make it possible to optionally mark functions defined by MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME as MOZ_OVERRIDE

Review of attachment 8543219 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/RefPtr.h
@@ +160,5 @@
>                                 MozRefCountType>::Type mRefCnt;
>  };
>  
>  #ifdef MOZ_REFCOUNTED_LEAK_CHECKING
> +#define MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(T, ...) \

Some comment here about what's appropriate in the varargs would be appreciated, similar to what you have for the XPCOM refcounting macros.
Attachment #8543219 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/58f7805a959f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.