Closed Bug 1117037 Opened 5 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8543220 - Flags: review?(tbsaunde+mozbugs)
Assignee: nobody → ehsan
Comment on attachment 8543220 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

r=me if you fix up the over long lines (a whole bunch are over 80 chars)
Attachment #8543220 - Flags: review?(tbsaunde+mozbugs) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> r=me if you fix up the over long lines (a whole bunch are over 80 chars)

Which lines specifically?  The code around most of what I touched currently has no respect for 80 column limit.
Flags: needinfo?(tbsaunde+mozbugs)
if there's a whole bunch of them before patching then it should be ok take the patch as is if you don't feel brave enough to fix them :)
Yep, thanks Alexander!  Bigger fish to fry and all.  :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/539768eaa7ba
https://hg.mozilla.org/mozilla-central/rev/539768eaa7ba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > r=me if you fix up the over long lines (a whole bunch are over 80 chars)
> 
> Which lines specifically?  The code around most of what I touched currently
> has no respect for 80 column limit.

I didn't look at the surrounding stuff.  I'd prefer we not add additional violations, but I don't really care for that rule anyway so whatever.
Flags: needinfo?(tbsaunde+mozbugs)
You need to log in before you can comment on or make changes to this bug.