Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

RESOLVED FIXED in mozilla37

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8543220 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in accessible/
Attachment #8543220 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1117034
Comment on attachment 8543220 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in accessible/

r=me if you fix up the over long lines (a whole bunch are over 80 chars)
Attachment #8543220 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> r=me if you fix up the over long lines (a whole bunch are over 80 chars)

Which lines specifically?  The code around most of what I touched currently has no respect for 80 column limit.
Flags: needinfo?(tbsaunde+mozbugs)

Comment 4

3 years ago
if there's a whole bunch of them before patching then it should be ok take the patch as is if you don't feel brave enough to fix them :)
(Assignee)

Comment 5

3 years ago
Yep, thanks Alexander!  Bigger fish to fry and all.  :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/539768eaa7ba
https://hg.mozilla.org/mozilla-central/rev/539768eaa7ba
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > r=me if you fix up the over long lines (a whole bunch are over 80 chars)
> 
> Which lines specifically?  The code around most of what I touched currently
> has no respect for 80 column limit.

I didn't look at the surrounding stuff.  I'd prefer we not add additional violations, but I don't really care for that rule anyway so whatever.
Flags: needinfo?(tbsaunde+mozbugs)
You need to log in before you can comment on or make changes to this bug.