Closed Bug 1117064 Opened 5 years ago Closed 5 years ago

Use localtime_s in ComputeLocalTime on Windows.

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch patch.diffSplinter Review
There is no localtime_r on Windows, but we may use localtime_s instead.

Also, this fixes build on latest mingw-w64, which introduced localtime_r in compatibility lib, but it's header declaration is hidden.
Attachment #8543243 - Flags: review?(till)
Comment on attachment 8543243 [details] [diff] [review]
patch.diff

Review of attachment 8543243 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!
Attachment #8543243 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/5dba1e33ab69
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.