Status
()
People
(Reporter: jonco, Assigned: jonco)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
22.64 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
As suggested in bug 1099152, there are loads of functions declared in js/public/GCAPI.h that are then defined in jsfriendapi.cpp. Also, they are also marked JS_FRIEND_API. These are part of the public API, so they should be marked JS_PUBLIC_API and defined in jsgc.cpp.
|
Assignee | |
Comment 1•5 years ago
|
||
As described above. I left APIs relating to gray marking as friend - potentially these should get moved to jsfriendapi.h
Attachment #8543291 -
Flags: review?(terrence)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 8543291 [details] [diff] [review] move-gc-api-methods-out-of-jsfriendapi Review of attachment 8543291 [details] [diff] [review]: ----------------------------------------------------------------- Woot!
Attachment #8543291 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4feee07c34ad
|
||
Comment 4•5 years ago
|
||
Backed out because bug 1099152 was backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/06ec26af14f3
|
|
Assignee | |
Comment 5•5 years ago
|
||
Re-landing: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ef764843840
|
||
Comment 6•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ef764843840
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•