1117098 - Public GC API functions should be defined in jsgc.cpp

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

As suggested in bug 1099152, there are loads of functions declared in js/public/GCAPI.h that are then defined in jsfriendapi.cpp.  Also, they are also marked JS_FRIEND_API.

These are part of the public API, so they should be marked JS_PUBLIC_API and defined in jsgc.cpp.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: move-gc-api-methods-out-of-jsfriendapi

As described above.  I left APIs relating to gray marking as friend - potentially these should get moved to jsfriendapi.h

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8543291 [details] [diff] [review]
move-gc-api-methods-out-of-jsfriendapi

Review of attachment 8543291 [details] [diff] [review]:
-----------------------------------------------------------------

Woot!

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4feee07c34ad

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out because bug 1099152 was backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/06ec26af14f3

Comment 5

[Jon Coppeard (:jonco)]

Re-landing:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ef764843840

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ef764843840