Closed Bug 1117098 Opened 6 years ago Closed 6 years ago

Public GC API functions should be defined in jsgc.cpp

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

move-gc-api-methods-out-of-jsfriendapi
22.64 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
As suggested in bug 1099152, there are loads of functions declared in js/public/GCAPI.h that are then defined in jsfriendapi.cpp.  Also, they are also marked JS_FRIEND_API.

These are part of the public API, so they should be marked JS_PUBLIC_API and defined in jsgc.cpp.
As described above.  I left APIs relating to gray marking as friend - potentially these should get moved to jsfriendapi.h
Attachment #8543291 - Flags: review?(terrence)
Comment on attachment 8543291 [details] [diff] [review]
move-gc-api-methods-out-of-jsfriendapi

Review of attachment 8543291 [details] [diff] [review]:
-----------------------------------------------------------------

Woot!
Attachment #8543291 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/2ef764843840
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.