Closed Bug 1117125 Opened 9 years ago Closed 8 years ago

Update b2g desktop in tbpl after bug 1101029 lands

Categories

(Firefox OS Graveyard :: Infrastructure, defect)

Product:
Firefox OS Graveyard
Component:
Infrastructure
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.6 S5 - 1/15

People

(Reporter: ferjm, Assigned: u520299)

References

Details

Attachments

(2 files, 1 obsolete file)

[gaia] ferjm:bug1117125.globaloverlaytest > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gwagner
: review+
Details | Review
[gaia] tilmankamp:fix-1117125 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review 
We need to update the b2g desktop that we use to run marionette tests in tbpl after bug 1101029. Once this is done, we can enable apps/system/test/marionette/global_overlay_window_test.js which is dependent of the new permission added in bug 1101029.
Is this still needed?
Flags: needinfo?(ferjmoreno)
 (In reply to Gregor Wagner [:gwagner] from comment #1)
> Is this still needed?

I don't know :) let see how treeherder goes.
Flags: needinfo?(ferjmoreno)
Comment on attachment 8652738 [details] [review]
[gaia] ferjm:bug1117125.globaloverlaytest > mozilla-b2g:master

It seems that treeherder is happy with the test
Attachment #8652738 - Flags: review?(anygregor)
Assignee: nobody → ferjmoreno
Attachment #8652738 - Flags: review?(anygregor) → review+
Oh, actually, treeherder is not that happy... :(
Assignee: ferjmoreno → nobody
Let's have Tilman take a look.
Assignee: nobody → tilmankamp
Target Milestone: --- → 2.6 S5 - 1/15
Comment on attachment 8705141 [details] [review]
[gaia] tilmankamp:fix-1117125 > mozilla-b2g:master

There was a wrong permission name in the fake app's manifest.
Attachment #8705141 - Flags: review?(mhenretty)
Great work. Seem like there were multiple improvements here. I ran the test locally and it was green. However, I think you still need to remove the test exception from the tbpl-manifest.json file in your pull request.
Flags: needinfo?(tilmankamp)
Comment on attachment 8705516 [details] [review]
[gaia] tilmankamp:fix-1117125 > mozilla-b2g:master

Removed test from blacklist.
Flags: needinfo?(tilmankamp)
Attachment #8705516 - Flags: review?(mhenretty)
Comment on attachment 8705516 [details] [review]
[gaia] tilmankamp:fix-1117125 > mozilla-b2g:master

Looking good now! Thanks for fixing up this test.
Attachment #8705516 - Flags: review?(mhenretty) → review+
Attachment #8705141 - Attachment is obsolete: true
Attachment #8705141 - Flags: review?(mhenretty)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: