Closed Bug 1117207 Opened 5 years ago Closed 5 years ago

Install the dictionaries in the misc tier

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(2 files)

No description provided.
Attachment #8543391 - Flags: review?(gps)
Comment on attachment 8543391 [details] [diff] [review]
Install the dictionaries in the misc tier

Review of attachment 8543391 [details] [diff] [review]:
-----------------------------------------------------------------

Pretty sure this will break l10n repacks because of the reference to $(LOCALE_SRCDIR). I'll r+ a patch to move this to INSTALL_TARGETS. But it needs to run during libs. Sorry :/
Attachment #8543391 - Flags: review?(gps) → review-
How should I have known that this won't work?  (Asking for future work.)
Assignee: nobody → ehsan
Flags: needinfo?(gps)
"you just know"

Anything with "locale" or "l10n" or related to jar.mn files will likely break l10n repacks. See also https://groups.google.com/d/msg/mozilla.dev.builds/1Y6cmEwuHr8/cpqPVyVVeyQJ
Flags: needinfo?(gps)
Attachment #8544905 - Flags: review?(gps)
Comment on attachment 8544905 [details] [diff] [review]
Use INSTALL_TARGETS to install dictionaries

Review of attachment 8544905 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/spellcheck/locales/Makefile.in
@@ +1,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +include $(topsrcdir)/config/config.mk

You can drop the include completely. config.mk gets included automagically.
Attachment #8544905 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #6)
> Comment on attachment 8544905 [details] [diff] [review]
> Use INSTALL_TARGETS to install dictionaries
> 
> Review of attachment 8544905 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: extensions/spellcheck/locales/Makefile.in
> @@ +1,5 @@
> >  # This Source Code Form is subject to the terms of the Mozilla Public
> >  # License, v. 2.0. If a copy of the MPL was not distributed with this
> >  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> >  
> > +include $(topsrcdir)/config/config.mk
> 
> You can drop the include completely. config.mk gets included automagically.

Only if he changes the := to a = for DICTIONARY_DEST.
not that config.mk gets included automagically if that change is made, but that not including config.mk first will make that := wrong because FINAL_TARGET is only defined after config.mk is included.
https://hg.mozilla.org/mozilla-central/rev/0cd58b83cbc9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.