Closed Bug 1117211 Opened 5 years ago Closed 5 years ago

Move the XPCOM gtests temporarily placed in xpcom/glue/tests/gtest into xpcom/test/gtest now that it exists

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8543400 [details] [diff] [review]
Move the XPCOM gtests temporarily placed in xpcom/glue/tests/gtest into xpcom/test/gtest now that it exists

Review of attachment 8543400 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the TestArray change.

::: xpcom/glue/tests/gtest/moz.build
@@ -4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  UNIFIED_SOURCES += [
> -    'TestArray.cpp',

We have other tests for nsTArray in this directory (TestGCPostBarriers.cpp), so we might as well keep TestArray.cpp here?
Attachment #8543400 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/8afa48feba29
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.