Uninline Debugger::isDebuggee() to fix -Wundefined-inline warning
RESOLVED
FIXED
in mozilla37
Status
()
People
(Reporter: cpeterson, Assigned: cpeterson)
Tracking
(Blocks: 1 bug)
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
3.13 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Created attachment 8543469 [details] [diff] [review] js-Debugger_Wundefined-inline.patch JSCompartment::maybeGlobal() is declared inline, but is called by Debugger::isDebuggee() before its inline definition has been seen: > Warning: -Wundefined-inline in js/src/jscompartment.h: inline function 'JSCompartment::maybeGlobal' is not defined > js/src/jscompartment.h:215:30: warning: inline function 'JSCompartment::maybeGlobal' is not defined [-Wundefined-inline] > inline js::GlobalObject *maybeGlobal() const; > ^ > js/src/vm/Debugger.h:239:72: note: used here > return compartment->isDebuggee() && debuggees.has(compartment->maybeGlobal()); > ^
Attachment #8543469 -
Flags: review?(shu)
|
||
Updated•4 years ago
|
Attachment #8543469 -
Flags: review?(shu) → review+
|
(Assignee) | |
Comment 1•4 years ago
|
||
Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/595796592856
|
||
Comment 2•4 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/595796592856
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•