Closed Bug 1117267 Opened 5 years ago Closed 5 years ago

Uninline Debugger::isDebuggee() to fix -Wundefined-inline warning

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

JSCompartment::maybeGlobal() is declared inline, but is called by Debugger::isDebuggee() before its inline definition has been seen:

> Warning: -Wundefined-inline in js/src/jscompartment.h: inline function 'JSCompartment::maybeGlobal' is not defined
> js/src/jscompartment.h:215:30: warning: inline function 'JSCompartment::maybeGlobal' is not defined [-Wundefined-inline]
>      inline js::GlobalObject *maybeGlobal() const;
>                               ^
> js/src/vm/Debugger.h:239:72: note: used here
>          return compartment->isDebuggee() && debuggees.has(compartment->maybeGlobal());
>                                                                         ^
Attachment #8543469 - Flags: review?(shu)
Attachment #8543469 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/595796592856
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.