Thunderbird 24 doesn't support using Promise as a constructor

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Provider: GData
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We need to go back to using deferred objects for TB24 compat. I've also separated the shim for Promise.jsm and PromiseUtils.jsm so that for cases where Promise.jsm exists but PromiseUtils.jsm doesn't, the native Promise implementation isn't overwritten.
(Assignee)

Comment 1

3 years ago
Created attachment 8543500 [details] [diff] [review]
Fix - v1
Attachment #8543500 - Flags: review?(mohit.kanwal)
(Assignee)

Updated

3 years ago
Blocks: 1117541
Comment on attachment 8543500 [details] [diff] [review]
Fix - v1

Review of attachment 8543500 [details] [diff] [review]:
-----------------------------------------------------------------

I think the parameter name should be changed to aDetail otherwise the promise won't get rejected.

::: calendar/providers/gdata/components/calGoogleCalendar.js
@@ +629,5 @@
> +        this.setProperty("lastUpdated.tasks", "");
> +        this.mThrottle = Object.create(null);
> +        this.mOfflineStorage.QueryInterface(Components.interfaces.calICalendarProvider)
> +                            .deleteCalendar(this.mOfflineStorage, {
> +            onDeleteCalendar: function(aCalendar, aStatus, aDetal) {

parameter is `aDetal` while it is getting rejected with `aDetail`. A typo?
Attachment #8543500 - Flags: review?(mohit.kanwal) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8553678 [details] [diff] [review]
Fix - v2

Luckily the promise would just be rejected with undefined, but here is the patch to fix the typo :)
Attachment #8543500 - Attachment is obsolete: true
Attachment #8553678 - Flags: review?(mohit.kanwal)
Comment on attachment 8553678 [details] [diff] [review]
Fix - v2

Review of attachment 8553678 [details] [diff] [review]:
-----------------------------------------------------------------

Looks Good :)
Attachment #8553678 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Target Milestone: --- → 4.0
(Assignee)

Comment 5

2 years ago
Pushed to comm-central changeset 2877aa0b36c2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.