Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Outdated client message shown when using obsolete token

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Provider: GData
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
1) Install an old provider version that still has a valid client key
2) Disable that calendar
3) Mark that old key invalid in the API Console (granted, you can't do this)
4) Update to a newer version with a valid client key
5) Enable calendar


Results:
* "unauthorized_client" message is shown in console
* Client outdated message is shown, even with new provider

Expected:
* Attempt to log in with new access token, ignoring the old token
(Assignee)

Comment 1

3 years ago
Created attachment 8543502 [details] [diff] [review]
Fix - v1
Attachment #8543502 - Flags: review?(mohit.kanwal)
(Assignee)

Updated

3 years ago
Blocks: 1117541
Comment on attachment 8543502 [details] [diff] [review]
Fix - v1

Review of attachment 8543502 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: calendar/providers/gdata/modules/gdataSession.jsm
@@ +243,5 @@
>                      this.notifyOutdated();
> +                } else if (error == "unauthorized_client") {
> +                    cal.ERROR("[calGoogleSession] Token for " + this.mId +
> +                              " is no longer authorized");
> +                    // We need to trigger a login without acecss token but want

oops type here in `acecss`
Attachment #8543502 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8552522 [details] [diff] [review]
Fix - v2

Thanks, here is the patch for checkin with the typo fixed!
Attachment #8543502 - Attachment is obsolete: true
Attachment #8552522 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

3 years ago
Pushed to comm-central changeset 181fc12cf180
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.