The Chat toolbar don't use the inverted icons on dark LW-themes

RESOLVED FIXED in Thunderbird 38.0

Status

Thunderbird
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 38.0
All
Windows 7
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird36 fixed, thunderbird37 fixed, thunderbird_esr3136+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I must somehow missed the Chat tab on the change from :-moz-lwtheme to [brighttext]. Also :-moz-lwtheme-darktext is the wrong selector for dark LW-themes.
(Assignee)

Comment 1

3 years ago
Created attachment 8543612 [details] [diff] [review]
chat-brighttext.patch

This fixes it using the correct selector.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8543612 - Flags: review?(josiah)
Attachment #8543612 - Flags: review?(josiah) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 2

3 years ago
https://hg.mozilla.org/comm-central/rev/e5bb8af1e7e4 -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
(Assignee)

Comment 3

3 years ago
Comment on attachment 8543612 [details] [diff] [review]
chat-brighttext.patch

[Approval Request Comment]
User impact if declined: harder visible icons with dark LW-theme.
Testing completed (on c-c, etc.): landed on c-c.
Risk to taking this patch (and alternatives if risky): low, only css changes.
Attachment #8543612 - Flags: approval-comm-esr31?
Attachment #8543612 - Flags: approval-comm-beta?
Attachment #8543612 - Flags: approval-comm-aurora?
Attachment #8543612 - Flags: approval-comm-esr31?
Attachment #8543612 - Flags: approval-comm-esr31+
Attachment #8543612 - Flags: approval-comm-beta?
Attachment #8543612 - Flags: approval-comm-beta+
Attachment #8543612 - Flags: approval-comm-aurora?
Attachment #8543612 - Flags: approval-comm-aurora+

Comment 4

3 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/96ba27d9faf5
https://hg.mozilla.org/releases/comm-beta/rev/0a756bf838d7
https://hg.mozilla.org/releases/comm-esr31/rev/f60d5fce54fc
status-thunderbird36: --- → fixed
status-thunderbird37: --- → fixed
status-thunderbird_esr31: --- → fixed

Updated

3 years ago
tracking-thunderbird_esr31: --- → 36+
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.