Closed
Bug 1117496
Opened 9 years ago
Closed 9 years ago
The Chat toolbar don't use the inverted icons on dark LW-themes
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird36 fixed, thunderbird37 fixed, thunderbird_esr3136+ fixed)
RESOLVED
FIXED
Thunderbird 38.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
jsbruner
:
review+
Sylvestre
:
approval-comm-aurora+
Sylvestre
:
approval-comm-beta+
Sylvestre
:
approval-comm-esr31+
|
Details | Diff | Splinter Review |
I must somehow missed the Chat tab on the change from :-moz-lwtheme to [brighttext]. Also :-moz-lwtheme-darktext is the wrong selector for dark LW-themes.
|
Assignee | |
Comment 1•9 years ago
|
||
This fixes it using the correct selector.
|
||
Updated•9 years ago
|
Attachment #8543612 -
Flags: review?(josiah) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/e5bb8af1e7e4 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8543612 [details] [diff] [review] chat-brighttext.patch [Approval Request Comment] User impact if declined: harder visible icons with dark LW-theme. Testing completed (on c-c, etc.): landed on c-c. Risk to taking this patch (and alternatives if risky): low, only css changes.
Attachment #8543612 -
Flags: approval-comm-esr31?
Attachment #8543612 -
Flags: approval-comm-beta?
Attachment #8543612 -
Flags: approval-comm-aurora?
|
||
Updated•9 years ago
|
Attachment #8543612 -
Flags: approval-comm-esr31?
Attachment #8543612 -
Flags: approval-comm-esr31+
Attachment #8543612 -
Flags: approval-comm-beta?
Attachment #8543612 -
Flags: approval-comm-beta+
Attachment #8543612 -
Flags: approval-comm-aurora?
Attachment #8543612 -
Flags: approval-comm-aurora+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/96ba27d9faf5 https://hg.mozilla.org/releases/comm-beta/rev/0a756bf838d7 https://hg.mozilla.org/releases/comm-esr31/rev/f60d5fce54fc
status-thunderbird36:
--- → fixed
status-thunderbird37:
--- → fixed
status-thunderbird_esr31:
--- → fixed
|
|
||
Updated•9 years ago
|
tracking-thunderbird_esr31:
--- → 36+
|
|
Assignee | |
Updated•9 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•