Note: There are a few cases of duplicates in user autocompletion which are being worked on.

useDefault not correctly set if there are no default alarms

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Provider: GData
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
1) Remove all default alarms from Google Calendar web interface
2) Set up calendar in Lightning
3) Create an event and set reminders to "Default"

Result:
* useDefault: false is sent to the server

Expected:
* useDefault: true should be sent to the server
(Assignee)

Comment 1

3 years ago
Created attachment 8543661 [details] [diff] [review]
Fix - v1
Attachment #8543661 - Flags: review?(mohit.kanwal)
Comment on attachment 8543661 [details] [diff] [review]
Fix - v1

Review of attachment 8543661 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine with the exception of what I think maybe a typo?

::: calendar/providers/gdata/modules/gdataUtils.jsm
@@ +698,3 @@
>  
> +                if (aDefaultReminders.length) {
> +                    item.deleteProperty("X-DEFAULT_ALARM");

Is this a typo? "X-DEFAULT-ALARM"
Attachment #8543661 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8550968 [details] [diff] [review]
Fix - v2

Great catch, thanks!
Attachment #8550968 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Attachment #8543661 - Attachment is obsolete: true
Attachment #8550968 - Flags: feedback+
(Assignee)

Updated

3 years ago
Blocks: 1117541
(Assignee)

Comment 4

3 years ago
Pushed to comm-central changeset ff705d73c703
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.