Closed
Bug 1117540
Opened 11 years ago
Closed 11 years ago
useDefault not correctly set if there are no default alarms
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.06 KB,
patch
|
Fallen
:
review+
redDragon
:
feedback+
|
Details | Diff | Splinter Review |
1) Remove all default alarms from Google Calendar web interface
2) Set up calendar in Lightning
3) Create an event and set reminders to "Default"
Result:
* useDefault: false is sent to the server
Expected:
* useDefault: true should be sent to the server
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8543661 -
Flags: review?(mohit.kanwal)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8543661 [details] [diff] [review]
Fix - v1
Review of attachment 8543661 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine with the exception of what I think maybe a typo?
::: calendar/providers/gdata/modules/gdataUtils.jsm
@@ +698,3 @@
>
> + if (aDefaultReminders.length) {
> + item.deleteProperty("X-DEFAULT_ALARM");
Is this a typo? "X-DEFAULT-ALARM"
Attachment #8543661 -
Flags: review?(mohit.kanwal) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8543661 -
Attachment is obsolete: true
|
|
||
Updated•11 years ago
|
Attachment #8550968 -
Flags: feedback+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pushed to comm-central changeset ff705d73c703
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•