Fix and run xpcshell tests for the provider

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Provider: GData
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
The test are skipped currently since there are a few minor errors that I didn't have time to fix. Mostly about variables declared twice and a small change needed after the throttling additions.
(Assignee)

Comment 1

2 years ago
Created attachment 8543668 [details] [diff] [review]
Fix - v1

https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=e48ab8fbfe94

Lets hope it works :)
Attachment #8543668 - Flags: review?(mohit.kanwal)
It almost worked :) looks like [getAllMeta(calendar)...][1] is returning only 1 item. Is it because of the same recurrence Id?

[1]: https://hg.mozilla.org/try-comm-central/file/befa4eabce68/calendar/test/unit/test_gdata_provider.js#l1153
(Assignee)

Comment 3

2 years ago
recurringEventId is the id of the orginal event, so it should be fine. I kind of wonder why it passed on opt and failed on debug and only happens on linux. I'm doing another try run now just for the hell of it, then I might do another few with more debug messages.
(Assignee)

Comment 4

2 years ago
Oh wait, I see what you mean. I missed to change the ID of the second exception, it is also go6ijb0b46hlpbu4eeu92njevo_20060610T160000Z. I've changed this now and have started a second try run:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=75ffffc78aea

I had to disable the ical.js tests, because they are failing horribly. This needs to be fixed before pushing of course.
Comment on attachment 8543668 [details] [diff] [review]
Fix - v1

Review of attachment 8543668 [details] [diff] [review]:
-----------------------------------------------------------------

Yep Looks like now it works
Attachment #8543668 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 6

2 years ago
Actually, I'm still seeing it on Linux debug:

TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_gdata_provider.js | test_metadata_recurring - [test_metadata_recurring : 1153] 1 == 3
(Assignee)

Comment 7

2 years ago
Created attachment 8552416 [details] [diff] [review]
Fix - v2

Here is an updated patch. It definitely passes on Linux:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d7c558d69ccd

I'm running a full try run after a few more small changes. I'll also have to file bugs for a few more patches so this one should be pushed last.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b1445f13fa1c
Attachment #8543668 - Attachment is obsolete: true
Attachment #8552416 - Flags: review?(mohit.kanwal)
(Assignee)

Updated

2 years ago
(Assignee)

Comment 8

2 years ago
Nice, tests pass. The failures are not caused by this patch.
Comment on attachment 8552416 [details] [diff] [review]
Fix - v2

Review of attachment 8552416 [details] [diff] [review]:
-----------------------------------------------------------------

All Good here!
Attachment #8552416 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 10

2 years ago
comm-central changeset 29b2f7fd82ac
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.