1117594 - |technique| can be used when uninitialized in ImageLayerD3D10::RenderLayer()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicholas Nethercote [inactive]]

cppcheck reports this:

> gfx/layers/d3d10/ImageLayerD3D10.cpp:313: error: Uninitialized variable: technique

If image->GetFormat() is one of CAIRO_SURFACE, D3D9_RGB32_TEXTURE or PLANAR_YCBCR then |technique| will be initialized. Otherwise, it won't be.

I see two possibilities:

- This is a real defect.

- This is not a real defect because the three above are the only possible values. If so, it would be good to add an |else| branch that crashes, or something like that, to make things clearer. Especially given that this is a large function with complex control flow.

I've marked this bug as security-sensitive to be cautious, but that may be overkill.

Comment 1

[Nicholas Nethercote [inactive]]

bas, what do you think? Is it a real defect?

Comment 2

[Bas Schouten (:bas.schouten)]

(In reply to Nicholas Nethercote [:njn] from comment #1)
> bas, what do you think? Is it a real defect?

Off the top of my head these are the only possible options. But it would probably be good to assert this or even as you suggested MOZ_CRASH. Especially in case someone changes this in the future.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Crash on unexpected image format in ImageLayerD3D10::RenderLayer()

Comment 4

[Nicholas Nethercote [inactive]]

This bug probably doesn't need the s-s tag any more, but I don't have permission to remove it.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03a624fda816

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03a624fda816