Closed Bug 1117623 Opened 5 years ago Closed 5 years ago

Undefined value error in TouchInputMapper::configureSurface()

Categories

(Core :: Widget, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

cppcheck says:

> widget/gonk/libui/InputReader.cpp:3030: error: Uninitialized variable: deviceModeChanged

It's correct.
Comment on attachment 8543752 [details] [diff] [review]
Fix undefined value error in TouchInputMapper::configureSurface()

Review of attachment 8543752 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this was fixed in lollipop. http://androidxref.com/5.0.0_r2/xref/frameworks/native/services/inputflinger/InputReader.cpp#3057
Attachment #8543752 - Flags: review?(mwu) → review+
I'll tweak it to be identical to the Lollipop code. Thank you for the review.
Flags: needinfo?(mwu)
Sounds good.
Flags: needinfo?(mwu)
https://hg.mozilla.org/mozilla-central/rev/c71e4fb1d36c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.