Test failure 'Notification popup state has been opened' in testSecurity/testSSLStatusAfterRestart.js

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Teodor Druta, Assigned: Daniela Domnici)

Tracking

Version 2
x86
All

Firefox Tracking Flags

(firefox34 unaffected, firefox35 unaffected, firefox36 fixed, firefox37 fixed, firefox38 fixed)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Module:    testDisplayCertificateStatusAfterRestart
Test:      testSecurity/testSSLStatusAfterRestart.js 
Failure:   Notification popup state has been closed
Branches:  mozilla-aurora
Platforms: Linux x86
Locale:    All 
Report:    http://mozmill-daily.blargon7.com/#/remote/report/5c7e7a22f9984b46554bc3b9fc44c734

Fails intermittently on Ubuntu 14.10, 14.04 x86.
(Reporter)

Comment 1

4 years ago
Just a small note I have mistakenly reported the failure message wrong, it should be:
"Notification popup state has been opened"
Summary: Test failure 'Notification popup state has been closed' in testSecurity/testSSLStatusAfterRestart.js → Test failure 'Notification popup state has been opened' in testSecurity/testSSLStatusAfterRestart.js
(Reporter)

Comment 2

4 years ago
This failed on Nightly, in the testDisplayCertificateStatus module, most probably it's the same issue.
http://mozmill-daily.blargon7.com/#/remote/report/04e54d608fc589a28217304fe674870e
status-firefox37: unaffected → affected
Failed about 20 times since friday on all platforms, aurora and nightly.

On beta I see it's only ubuntu 14.10 affected, but nightly and aurora has all:
http://mozmill-daily.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2015-01-16&to=&test=%2FtestSecurity%2FtestSSLStatusAfterRestart.js&func=testDisplayCertificateStatus
status-firefox38: --- → affected
OS: Linux → All
(Assignee)

Comment 6

3 years ago
Created attachment 8558377 [details] [diff] [review]
skip patch for beta

Created the skip patch for beta branch.
Attachment #8558377 - Flags: review?(mihaela.velimiroviciu)
Attachment #8558377 - Flags: review?(andreea.matei)
Attachment #8558377 - Flags: review?(mihaela.velimiroviciu)
Attachment #8558377 - Flags: review?(andreea.matei)
Attachment #8558377 - Flags: review+
https://hg.mozilla.org/qa/mozmill-tests/rev/3385ed64bddb (beta)
status-firefox36: affected → disabled
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
(Assignee)

Comment 8

3 years ago
I`ve investigated today this bug and I fixed it, tomorrow I `ll run  more testruns on ubuntu 14.04 production machine.Today I`ve did ~30 testruns on ubuntu 14.04 staging machine and ~20 testruns on ubuntu 14.04 production machine.
Here are the results: http://mozmill-crowd.blargon7.com/#/remote/reports?app=All&branch=36&platform=Linux&from=2015-02-03&to=2015-02-03
(Assignee)

Comment 9

3 years ago
Created attachment 8559115 [details] [diff] [review]
fix testSSLStatusAfterRestart.js

Created a fix patch for this test.This patch also fix the bug 1122541. I`ve did ~150 testruns on ubuntu 14.04-32-2 production machine.

Reports:http://mozmill-crowd.blargon7.com/#/remote/reports?app=All&branch=All&platform=All&from=2015-02-04&to=2015-02-04
Attachment #8559115 - Flags: review?(mihaela.velimiroviciu)
Attachment #8559115 - Flags: review?(andreea.matei)
Comment on attachment 8559115 [details] [diff] [review]
fix testSSLStatusAfterRestart.js

Review of attachment 8559115 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSSLStatusAfterRestart.js
@@ +51,5 @@
>  function teardownTest(aModule) {
>    if (persisted.nextTest) {
>      controller.restartApplication(persisted.nextTest);
>    }
> +  aModule.tabBrowser.closeAllTabs();

Why do we need to close tabs after each test?
Comment on attachment 8559115 [details] [diff] [review]
fix testSSLStatusAfterRestart.js

Review of attachment 8559115 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSSLStatusAfterRestart.js
@@ +51,5 @@
>  function teardownTest(aModule) {
>    if (persisted.nextTest) {
>      controller.restartApplication(persisted.nextTest);
>    }
> +  aModule.tabBrowser.closeAllTabs();

This line of code is not reached

@@ -55,4 @@
>  }
>  
>  function teardownModule(aModule) {
> -  aModule.tabBrowser.closeAllTabs();

Please add this line back
Attachment #8559115 - Flags: review?(mihaela.velimiroviciu)
Attachment #8559115 - Flags: review?(andreea.matei)
Attachment #8559115 - Flags: review-
(Assignee)

Comment 12

3 years ago
Please ignore the patch above.It seems that Cosmin`s closeTabs refactor solve this problem. Today, I`ve did 100 remote - testruns using 14.04-32-2 production machine and it didn`t fail at all.

Here are the results: 
http://mozmill-crowd.blargon7.com/#/remote/reports?app=All&branch=36&platform=All&from=2015-02-05&to=2015-02-05.
Great. Then we can mark this as fixed for now. Hopefully won't fail again :)
https://hg.mozilla.org/qa/mozmill-tests/rev/17fa1493b539 (beta)
Assignee: nobody → daniela.domnici
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox36: disabled → fixed
status-firefox37: affected → fixed
status-firefox38: affected → fixed
Resolution: --- → FIXED
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
You need to log in before you can comment on or make changes to this bug.