1117748 - Build bluetoothd on all JB and KK targets

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We need to build bluetoothd on all JB and KK platforms. L can follow in a separate bug when the port is ready. Turning on builds before we actually use the daemon it will give people time to pick up this change and spot errors during the building process.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for platform_build for emulator-jb

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for platform_build for emulator-kk

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-mako for nexus4

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-mako for nexus4-kk

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-flame for flame-kk

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-flo

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-hammerhead for nexus-5

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Michael,

These are just one liners in some Makefiles.

Comment 9

[Michael Wu [:mwu]]

Why not add bluetoothd to gonk-misc/b2g.mk?

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Michael Wu [:mwu] from comment #9)
> Why not add bluetoothd to gonk-misc/b2g.mk?

I followed what nfcd did. Would b2g.mk be the correct place? Does this work on ICS? Bluetoothd is only for JB and later.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for gonk-misc

Hi Michael,

Here's the pull request for gonk-misk. On old ICS branches this builds BlueZ's implementation of bluetoothd.

Comment 12

[Michael Wu [:mwu]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> (In reply to Michael Wu [:mwu] from comment #9)
> > Why not add bluetoothd to gonk-misc/b2g.mk?
> 
> I followed what nfcd did. Would b2g.mk be the correct place? Does this work
> on ICS? Bluetoothd is only for JB and later.

Packages on the list that aren't actually there just get ignored, so it should be fine.

NFC is a bit less common than bluetooth so it makes more sense to add it per device, though putting nfc in b2g.mk wouldn't bother me either.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gonk-misc/commit/cd63c7ae655ee08ffac32ce36a188f8fefc4b272