Closed Bug 1117748 Opened 5 years ago Closed 5 years ago

Build bluetoothd on all JB and KK targets

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.2+, b2g-v2.2 fixed)

RESOLVED FIXED
2.2 S3 (9jan)
feature-b2g 2.2+
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(1 file, 7 obsolete files)

We need to build bluetoothd on all JB and KK platforms. L can follow in a separate bug when the port is ready. Turning on builds before we actually use the daemon it will give people time to pick up this change and spot errors during the building process.
Attachment #8543975 - Attachment description: Github pull request for platform_build on JB → Github pull request for platform_build for emulator-jb
Attachment #8543978 - Attachment description: Github pull request for platform_build on KK → Github pull request for platform_build for emulator-kk
Attachment #8543984 - Attachment description: Github pull request for device-make for nexus4 → Github pull request for device-mako for nexus4
Attachment #8543990 - Attachment description: Github pull request for device-make for nexus4-kk → Github pull request for device-mako for nexus4-kk
Attachment #8543975 - Flags: review?(mwu)
Attachment #8543978 - Flags: review?(mwu)
Attachment #8543984 - Flags: review?(mwu)
Attachment #8543990 - Flags: review?(mwu)
Attachment #8544042 - Flags: review?(mwu)
Attachment #8544046 - Flags: review?(mwu)
Attachment #8544051 - Flags: review?(mwu)
Hi Michael,

These are just one liners in some Makefiles.
Why not add bluetoothd to gonk-misc/b2g.mk?
(In reply to Michael Wu [:mwu] from comment #9)
> Why not add bluetoothd to gonk-misc/b2g.mk?

I followed what nfcd did. Would b2g.mk be the correct place? Does this work on ICS? Bluetoothd is only for JB and later.
Hi Michael,

Here's the pull request for gonk-misk. On old ICS branches this builds BlueZ's implementation of bluetoothd.
Attachment #8545189 - Flags: review?(mwu)
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #10)
> (In reply to Michael Wu [:mwu] from comment #9)
> > Why not add bluetoothd to gonk-misc/b2g.mk?
> 
> I followed what nfcd did. Would b2g.mk be the correct place? Does this work
> on ICS? Bluetoothd is only for JB and later.

Packages on the list that aren't actually there just get ignored, so it should be fine.

NFC is a bit less common than bluetooth so it makes more sense to add it per device, though putting nfc in b2g.mk wouldn't bother me either.
Attachment #8545189 - Flags: review?(mwu) → review+
feature-b2g: --- → 2.2+
Target Milestone: --- → 2.2 S4 (23jan)
Attachment #8543975 - Attachment is obsolete: true
Attachment #8543975 - Flags: review?(mwu)
Attachment #8543978 - Attachment is obsolete: true
Attachment #8543978 - Flags: review?(mwu)
Attachment #8543984 - Attachment is obsolete: true
Attachment #8543984 - Flags: review?(mwu)
Attachment #8543990 - Attachment is obsolete: true
Attachment #8543990 - Flags: review?(mwu)
Attachment #8544042 - Attachment is obsolete: true
Attachment #8544042 - Flags: review?(mwu)
Attachment #8544046 - Attachment is obsolete: true
Attachment #8544046 - Flags: review?(mwu)
Attachment #8544051 - Attachment is obsolete: true
Attachment #8544051 - Flags: review?(mwu)
Master: https://github.com/mozilla-b2g/gonk-misc/commit/cd63c7ae655ee08ffac32ce36a188f8fefc4b272
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: 2.2 S4 (23jan) → 2.2 S3 (9jan)
You need to log in before you can comment on or make changes to this bug.