Closed Bug 1117777 Opened 5 years ago Closed 5 years ago

MP4 playback is inverted on Android

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
All
Android
Type:
defect
Priority:
Not set

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
firefox37 --- fixed
fennec 37+ ---

People

(Reporter: blassey, Assigned: snorp)

References

(
URL
)

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Fix inverted MP4 videos on Android
2.08 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #858139 +++

https://twitter.com/doublec/status/319640238576242688

So... an improvement. Two years ago they didn't play at all.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1116469
Bug 1116469 is different.

Snorp says, 

> Pretty sure this is caused by bug 1100699
Status: RESOLVED → REOPENED
status-firefox37: --- → affected
Keywords: regression, reproducible
OS: Mac OS X → Android
Hardware: x86 → All
Resolution: DUPLICATE → ---
Summary: these mp4 videos play upside down in Firefox on my Nexus 5 → MP4 playback is inverted on Android
Blocks: 1100699
I don't fully understand why this change is necessary, but it fixes the problem.
Attachment #8544050 - Flags: review?(jgilbert)
Flags: in-testsuite?
Comment on attachment 8544050 [details] [diff] [review]
Fix inverted MP4 videos on Android

Review of attachment 8544050 [details] [diff] [review]:
-----------------------------------------------------------------

Are both these changes necessary?
Attachment #8544050 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #4)
> Comment on attachment 8544050 [details] [diff] [review]
> Fix inverted MP4 videos on Android
> 
> Review of attachment 8544050 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Are both these changes necessary?

Yeah, the GLImages change was necessary to fix thumbnailing (which was also upside down).
https://hg.mozilla.org/mozilla-central/rev/6461b8a32d0e
Assignee: nobody → snorp
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Verified as fixed on latest Nightly on Nexus 7 (Android 5.0.1)
Verified as fixed on latest Nightly on Nexus 7 (Android 5.0.1)
Status: RESOLVED → VERIFIED
status-firefox37: affected → fixed
tracking-fennec: ? → 37+
You need to log in before you can comment on or make changes to this bug.