1117795 - Hello panel window cannot be dismissed during first step of the Ui Tour

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Catalin Varga [QA][:VarCat]]

Environment:

FF 37
Build id: 20150105030202
loop.gettingStarted.url = https://www-demo2.allizom.org/%LOCALE%/firefox/%VERSION%/hello/start/ 
OS: Win 7 x64, Ubuntu 14 x64

STR:

1. Start the Hello Ui Tour.
2. On the first step of the Ui Tour try to dismiss the Hello panel window.

Issue:
The Hello panel window cannot be dismissed.

Comment 1

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Alex - is this the same as bug 1113896 where we can close the panel on page clicks and tab moves?

Comment 2

[Alex Gibson [:agibson]]

(In reply to Cory Price [:ckprice] from comment #1)
> Alex - is this the same as bug 1113896 where we can close the panel on page
> clicks and tab moves?

Yes correct. I think this is fine in terms of the FTE and not a blocker, although it would be good to be able to close the Hello Panel by clicking the icon again.

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

:agibson - the FTUE tour is closing on tab moves/refreshes, but it's not closing on document clicks. After talking with Holly, we think it may be correct to put this functionality in (closing on document clicks), as it would be in line with how other feature panels react (minus the clicking on the icon of course), as well as the product page.

Let me know what you think.

Comment 4

[Alex Gibson [:agibson]]

(In reply to Cory Price [:ckprice] from comment #3)
> :agibson - the FTUE tour is closing on tab moves/refreshes, but it's not
> closing on document clicks. After talking with Holly, we think it may be
> correct to put this functionality in (closing on document clicks), as it
> would be in line with how other feature panels react (minus the clicking on
> the icon of course), as well as the product page.
> 
> Let me know what you think.

I can add a click handler on document to close the panel, but this will mean that if someone accidently clicks on the page before reading the first door-hanger, they will be unable to see it again a second time. If you and Holly are ok with this, let me know and I'll see to it.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

I'm really not a fan of either experience, but I don't think it's correct the way it is now.

If someone wants out of the panel, they should be able to click out. Although the act is not as implicit as clicking on the icon, I think the majority of users who click on the document will do so because they want the panel to go away.

They could always re-open the panel if they like and engage with Hello (albeit without the doorhanger).

:habber?

Comment 6

[Alex Gibson [:agibson]]

Once Bug 1113896 is verified fixed, i think we can probably just mark this bug resolved?

Comment 7

[Alex Gibson [:agibson]]

As of today's Nightly 38.0a1 (2015-02-11), clicking the Hello icon again once showMenu('loop') has been called now closes the menu as expected, so marking this one as fixed and clearing needsinfo for Holly.