111795 - [mach] buttons do not render properly

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Jeff Hume]

In the mach-o OS X builds buttons in chrome do not render properly. They appear
normally except it appears that half the button is rendered again to the left of
the original button. It looks like the button has an echo.

Comment 1

[Asa Dotzler [:asa]]

->toolkit?

Comment 2

[John Morrison]

mach-o, mach-o, man

Comment 3

[Mike Pinkerton (not reading bugmail)]

over to dbaron for the time being. he seems to be on a roll and i'm sure this is
nothing more than a forgotten ifdef somewhere. i'll take it back if he's too
overloaded.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I don't think it's a forgotten #ifdef, and even if it were, I don't know where
it would be.  I really have no idea why we'd have two different ideas of where
the button should be, anyway.  Back to pinkerton.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

After looking at the flames background images on tinderbox overflow, I realized
that this is probably because we're not properly clipping tiled background images.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The clipping problem seems specific to background images.  There are massive
problems on http://www.w3.org/Style/CSS/Test/current/sec534.htm when resizing
the page but http://www.people.fas.harvard.edu/~dbaron/css/test/sec110102 seems OK.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The fix is in nsCSSRendering.cpp -- defining XP_UNIX got us in trouble here. 
I'll attach that fix, along with two other ifdef tweaks that I found along the
way and don't seem to do any harm.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 9

[Javier Pedemonte]

*** Bug 107215 has been marked as a duplicate of this bug. ***

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 60009 [details] [diff] [review]
patch

r=pink. and you said it wasn't ifdef-fu ;)

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Taking

Comment 12

[Simon Fraser [no longer active]]

Comment on attachment 60009 [details] [diff] [review]
patch

sr=sfraser

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2001-12-05 16:09 PDT.