1117951 - Wrong Flash events after dismissal of context menu

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[spikezq]

Attachment: Screen Shot 2015-01-05 at 3.33.13 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

I opened the Flash context menu on an object in my application.  From here if I click on any of the options or click outside of the context menu it triggers the bug.


Actual results:

What happens is that the app handles the event as if I have/am holding down the mouse button on the object I opened the context menu on.  In our app this results in an object being dragged and following the mouse until you click again.


Expected results:

If click outside the context menu, nothing should happen.  If I select one of the options in the context menu it should trigger just the event I chose, not the additional mouse dragging that happens afterwards currently.

Comment 1

[spikezq]

This doesn't happen in 33.1, updated to 34.0.5 and it started happening.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

We need more than a screenshot here.

Please give us a publicly accessible link to your "application", or some other Flash object, together with precise, detailed (and written) steps to reproduce.

Comment 3

[spikezq]

Attachment: SWF mouse event tester w/ more screenshots

Launch the rightclicktest.swf file in Firefox and Chrome.  To test our issue, right click anywhere in the window and then left click somewhere else in the window.  In Chrome, no mouse down event.  Works fine.  Firefox, you get a mouse down event with no mouse up event which causes a drag in our app.

Comment 4

[Stephen A Pohl [:spohl]]

I'll try to get to this tomorrow.

Comment 5

[Stephen A Pohl [:spohl]]

I've finally been able to look into this. Here is the history of our behavior:

1. Prior to 2014-05-01[1]: The events after dismissing the context menu were: mouseMove, mouseDown, mouseUp, click.
2. After 2014-05-02 until 2014-07-30: The only event after dismissing the context menu was: mouseMove
3. After 2014-07-31 until 2014-12-11: The events after dismissing the context menu were: mouseMove, mouseDown (this is the issue reported in this bug).
4. After 2014-12-12, the issue was fixed by the rewrite in bug 1092630 that got rid of native widgets for OSX NPAPI plugins. The event after dismissing the context menu was back to mouseMove only.

The changeset range between 2 and 3 that introduced the mouseDown event is: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f61a27b00e05&tochange=005424a764da

Comment 6

[Stephen A Pohl [:spohl]]

Bug 1092630 is tracking for Firefox 37. I don't believe we want to take the risk of uplifting such a large change (including all followup bugs), so if we need a fix for 35 and/or 36, we would need to write separate patches for these branches.

Comment 7

[Stephen A Pohl [:spohl]]

[Tracking Requested - why for this release]:

Just wanted to get final confirmation that this will indeed be WONTFIX for 36. If so, I believe this bug can be closed as fixed in FF37.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

It is too late indeed for 36.

Next time, don't hesitate to bring that sooner to our attention. Submit for tracking as soon as you find a critical bug.

Comment 9

[Steven Michaud [:smichaud] (Retired)]

Marking this fixed, as per comment #7.