1117958 - "mach run" should treat --debugger just like other mach commands

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew McCreight [:mccr8]]

When I try to use mach run to run Firefox with the debugger, it just seems to run it without the debugger.

$ ./mach run --debugger lldb 
 0:00.36 /Users/amccreight/mc/obj-dbg.noindex/dist/NightlyDebug.app/Contents/MacOS/firefox -no-remote -foreground -profile /Users/amccreight/mc/obj-dbg.noindex/tmp/scratch_user

Note that if I omit the "lldb" it complains that debugger is missing an argument, so there's something happening.  This is on OSX.

Comment 1

[u459114]

You may try this command
./mach run --debug --debugger lldb

Comment 2

[u459114]

https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#943

In current design logic, --debugger argument will be respected only if --debug arguement exists.

Comment 3

[u459114]

Ok, I noticed that command line help string reveal this dependency:
$ ./mach run -h

Command Arguments for debugging:
  --debug               Enable the debugger. Not specifying a --debugger
                        option will result in the default debugger being used.
                        The following arguments have no effect without this. <<<<<<
  --debugger DEBUGGER   Name of debugger to use.

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to C.J. Ku[:cjku] from comment #2)
> In current design logic, --debugger argument will be respected only if
> --debug arguement exists.

Seems like we could fix this by just making that
if debug or debugger:

...so that --debugger implies --debug.

Comment 5

[u459114]

if debug or debugger or debugparams
Alternative, we may output an error message, tell user "--debugger/debugparams" depends on "--debug".

Comment 7

[(not currently active) Ted Mielczarek]

The summary from dbaron's bug is better.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

According to mach file-info bugzilla-component python/mozbuild/mozbuild/mach_commands.py this belongs in Build Config.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8608922 [details] [diff] [review]
Patch

Review of attachment 8608922 [details] [diff] [review]:
-----------------------------------------------------------------

Clear UX win. Great enhancement.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b94f0b47183

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8b94f0b47183