Closed Bug 1117984 Opened 5 years ago Closed 4 years ago

Should wait for 200 response before writing in nr_socket_proxy_tunnel_write

Categories

(Core :: WebRTC: Networking, defect, P3)

34 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed
Blocking Flags:

People

(Reporter: ryan, Assigned: drno)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

Write immediately after sending HTTP CONNECT



Expected results:

After sending CONNECT return R_WOULDBLOCK until connect_received && !connect_failed
Depends on: 949703
Product: Firefox → Core
Hi, 

This problem was fixed in version 38, if you still have this issue please let us know.
Component: Untriaged → WebRTC: Networking
Flags: needinfo?(ryan)
The bug is real and still alive: https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/net/nr_proxy_tunnel.c#329
Status: UNCONFIRMED → NEW
backlog: --- → webrtc/webaudio+
Rank: 35
Ever confirmed: true
Flags: needinfo?(ryan)
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Attachment #8710814 - Flags: review?(docfaraday)
Assignee: nobody → drno
Attachment #8710814 - Attachment description: MozReview Request: Bug 1117984: added proxy connection state enum → MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31877/diff/1-2/
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc

https://reviewboard.mozilla.org/r/31877/#review28675

::: media/mtransport/third_party/nICEr/src/stun/nr_socket_buffered_stun.c:527
(Diff revision 2)
> +  if (sock->read_state == NR_ICE_SOCKET_READ_FAILED) {

This was confusing because NR_ICE_SOCKET_READ_FAILED is a misnomer, since it is also used when there are write failures. We should probably clean this up, but in a separate ticket.
Attachment #8710814 - Flags: review?(docfaraday) → review+
Comment on attachment 8710814 [details]
MozReview Request: Bug 1117984: added proxy connection state enum. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31877/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/2351ccd7fe59
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.