1118027 - fix some compile warnings in compose/src/nsMsgSend.cpp

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[:aceman]

On gcc 4.8:

mailnews/compose/src/nsMsgSend.cpp: In member function 'virtual nsresult nsMsgComposeAndSend::GatherMimeAttachments()':
mailnews/compose/src/nsMsgSend.cpp:430:8: warning: variable 'multipart_p' set but not used [-Wunused-but-set-variable]
   bool multipart_p = false;
        ^
mailnews/compose/src/nsMsgSend.cpp:431:8: warning: variable 'plaintext_is_mainbody_p' set but not used [-Wunused-but-set-variable]
   bool plaintext_is_mainbody_p = false; // only using text converted from HTML?
        ^
mailnews/compose/src/nsMsgSend.cpp:433:9: warning: variable 'buffer_tail' set but not used [-Wunused-but-set-variable]
   char *buffer_tail = 0;
         ^
mailnews/compose/src/nsMsgSend.cpp:435:8: warning: variable 'tonews' set but not used [-Wunused-but-set-variable]
   bool tonews;
        ^
mailnews/compose/src/nsMsgSend.cpp: In member function 'nsresult nsMsgComposeAndSend::HackAttachments(nsIArray*, nsIArray*)':
mailnews/compose/src/nsMsgSend.cpp:2380:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int i = 0; i < m_attachment_count; i++) {
                       ^

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8544249 [details] [diff] [review]
patch

Review of attachment 8544249 [details] [diff] [review]:
-----------------------------------------------------------------

Most of this patch doesn't apply anymore.

Comment 3

[:aceman]

Attachment: patch v2

Right, so only this remains.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Sorry but I had bug 1114328 ongoing for two weeks. This has just been merged but maybe your last change is still relevant (-Wsign-compare).

Comment 5

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8547109 [details] [diff] [review]
patch v2

Review of attachment 8547109 [details] [diff] [review]:
-----------------------------------------------------------------

This patch appears to have been superseded.

Comment 6

[:aceman]

Attachment: patch v2.1

Yeah, suddenly everybody wants into this file ;)

Comment 7

[:aceman]

Thanks.

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/24fd67735890 -> FIXED