Closed Bug 1118031 Opened 5 years ago Closed 5 years ago

Windows PluginModuleParent leaks its toolhelp32 snapshot

Categories

(Core :: Plug-ins, defect)

x86
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

Noticed by dmajor.
Comment on attachment 8544259 [details] [diff] [review]
Fix toolhelp32 snapshot leak

Bah, I reviewed this code.
Attachment #8544259 - Flags: review?(jmathies) → review+
Comment on attachment 8544259 [details] [diff] [review]
Fix toolhelp32 snapshot leak

Approval Request Comment
[Feature/regressing bug #]: flash child process crash reporter
[User impact if declined]: On Windows, memory is leaked every time plugin-container is started for a plugin.
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: None, trivial patch
[String/UUID change made/needed]: None
Attachment #8544259 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e9535d758389
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attachment #8544259 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.