1118044 - Use GCCellPtr more in CycleCollectedJSRuntime

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

After these patches, the only place we're passing around void* and the tracekind separately are in JSGCThingParticipant::Traverse (which will be fixed by bug 1118026), and for code that has to interact with the JS_TraceChildren API, which currently requires it.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use GCCellPtr in CycleCollectedJSRuntime::TraverseGCThing.

This should not change any behavior.

try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8aa0354ca01e

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use GCCellPtr in NoteJSChild.

Also, strongly type the JS_TraceShapeCycleCollectorChildren function, and add an
isShape() method to GCCellPtr.

r=terrence for the JS engine changes, r=smaug for the rest

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8545350 [details] [diff] [review]
part 2 - Use GCCellPtr in NoteJSChild.

Review of attachment 8545350 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 4

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3941c5858c22
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eabd210312f9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3941c5858c22
https://hg.mozilla.org/mozilla-central/rev/eabd210312f9