Closed Bug 1118044 Opened 6 years ago Closed 6 years ago

Use GCCellPtr more in CycleCollectedJSRuntime

Categories

(Core :: XPCOM, defect)

32 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(2 files)

After these patches, the only place we're passing around void* and the tracekind separately are in JSGCThingParticipant::Traverse (which will be fixed by bug 1118026), and for code that has to interact with the JS_TraceChildren API, which currently requires it.
Also, strongly type the JS_TraceShapeCycleCollectorChildren function, and add an
isShape() method to GCCellPtr.

r=terrence for the JS engine changes, r=smaug for the rest
Attachment #8545350 - Flags: review?(terrence)
Attachment #8545350 - Flags: review?(bugs)
Attachment #8545349 - Flags: review?(bugs) → review+
Attachment #8545350 - Flags: review?(bugs) → review+
Comment on attachment 8545350 [details] [diff] [review]
part 2 - Use GCCellPtr in NoteJSChild.

Review of attachment 8545350 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8545350 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/3941c5858c22
https://hg.mozilla.org/mozilla-central/rev/eabd210312f9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.