Replace core data with sqlite

RESOLVED FIXED

Status

()

Firefox for iOS
Data Storage
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
There's a lot of trepedation around using CoreData and eventually finding ourselves handicapped. We're going to try switching to sqlite. I'm also going to say lets use FMDB as a sqlite abstraction layer. Its well updated and used frequently. Its job isn't to hide the sqlite from our eyes. Just to make working with it easier.

https://github.com/ccgus/fmdb
(Trying out our new "iOS 8" OS field!)
Status: NEW → ASSIGNED
Component: General → Data Storage
OS: Mac OS X → iOS 8
Hardware: x86 → All
(Assignee)

Comment 2

4 years ago
Created attachment 8544270 [details] [review]
Pull request

This removes Magical Record and instead inserts FMDB. I removed all of our current MR and ManagedObject code as well.
Attachment #8544270 - Flags: review?(sarentz)
Comment on attachment 8544270 [details] [review]
Pull request

LGTM
Attachment #8544270 - Flags: review?(sarentz) → review+
Assignee: nobody → wjohnston
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.