"settings" icon isnot highlight.

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: hirohisa.kawasaki, Assigned: hirohisa.kawasaki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
go-out current mark in tabs bar on changing tabs' enable/disable on settings

Comment 1

4 years ago
This bug doesn't have enough detail to be actionable. Please provide more details.

I'm removing the security flag, as this is not a security sensitive report.
Group: core-security
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
(Assignee)

Comment 2

4 years ago
Created attachment 8544501 [details]
not_highlight.png

1. Open SettingsViewController, then "settings" icon is highlight.
2. Tabs, Bookmarks, History or Reader is disabled.
3. "settings" icon isnot highlight.
(Assignee)

Updated

4 years ago
Component: Home screen → General
(Assignee)

Updated

4 years ago
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
(Assignee)

Comment 3

4 years ago
@Gijis, Thanks. I add details.
(Assignee)

Updated

4 years ago
Summary: go out current mark in tabs bar on settings → "settings" icon isnot highlight.
Created attachment 8547842 [details] [review]
Pull request

Wes, handing this review to you since I think you worked on the settings pane.
Attachment #8547842 - Flags: review?(wjohnston)
Assignee: nobody → hirohisa.kawasaki
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8547842 [details] [review]
Pull request

I think this is on the right track, but I'd like to do a bit less if we can. Can we?
Attachment #8547842 - Flags: review?(wjohnston) → feedback+
I don't know if we should put time in this UI because it will all change soon, based on most recent designs. No?
(Assignee)

Comment 7

3 years ago
I see, this issue will close. OK?
(Assignee)

Comment 8

3 years ago
I pushed new commit 11 day ago.
Flags: sec-review?
(Assignee)

Comment 9

3 years ago
Sorry, I mistake to add sec-review
Flags: sec-review?
(Assignee)

Comment 10

3 years ago
Created attachment 8558541 [details]
pushed new commit for review

Thanks @wesj  ! Sorry, I have used bugzilla first time.
Flags: needinfo?(wjohnston)
Attachment #8558541 - Flags: review?(wjohnston)
Comment on attachment 8558541 [details]
pushed new commit for review

Yay! Thanks!
Flags: needinfo?(wjohnston)
Attachment #8558541 - Flags: review?(wjohnston) → review+
I see hirohisa closed the PR, but did this ever get merged?
Flags: needinfo?(wjohnston)
Not sure, but I know you changed this code a lot recently. Lets close it.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago3 years ago
Flags: needinfo?(wjohnston)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.