Closed Bug 1118127 Opened 9 years ago Closed 9 years ago

"settings" icon isnot highlight.

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: hirohisa.kawasaki, Assigned: hirohisa.kawasaki)

Details

Attachments

(3 files)

not_highlight.png
112.47 KB, image/png
Details
Pull request
46 bytes, text/x-github-pull-request
wesj
: feedback+
Details | Review
pushed new commit for review
87 bytes, text/plain
wesj
: review+
Details 
go-out current mark in tabs bar on changing tabs' enable/disable on settings
This bug doesn't have enough detail to be actionable. Please provide more details.

I'm removing the security flag, as this is not a security sensitive report.
Group: core-security
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Attached image not_highlight.png — 
1. Open SettingsViewController, then "settings" icon is highlight.
2. Tabs, Bookmarks, History or Reader is disabled.
3. "settings" icon isnot highlight.
Component: Home screen → General
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
@Gijis, Thanks. I add details.
Summary: go out current mark in tabs bar on settings → "settings" icon isnot highlight.
Attached file Pull request — 
Wes, handing this review to you since I think you worked on the settings pane.
Attachment #8547842 - Flags: review?(wjohnston)
Assignee: nobody → hirohisa.kawasaki
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8547842 [details] [review]
Pull request

I think this is on the right track, but I'd like to do a bit less if we can. Can we?
Attachment #8547842 - Flags: review?(wjohnston) → feedback+
I don't know if we should put time in this UI because it will all change soon, based on most recent designs. No?
I see, this issue will close. OK?
I pushed new commit 11 day ago.
Flags: sec-review?
Sorry, I mistake to add sec-review
Flags: sec-review?
Thanks @wesj  ! Sorry, I have used bugzilla first time.
Flags: needinfo?(wjohnston)
Attachment #8558541 - Flags: review?(wjohnston)
Comment on attachment 8558541 [details]
pushed new commit for review

Yay! Thanks!
Flags: needinfo?(wjohnston)
Attachment #8558541 - Flags: review?(wjohnston) → review+
I see hirohisa closed the PR, but did this ever get merged?
Flags: needinfo?(wjohnston)
Not sure, but I know you changed this code a lot recently. Lets close it.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(wjohnston)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: