Clicking search field's magnifying glass icon no longer dismisses search field's dropdown menu

RESOLVED FIXED in Firefox 36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: mossop)

Tracking

({regression})

unspecified
Firefox 38
x86
Mac OS X
regression
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox35 wontfix, firefox36+ fixed, firefox37 fixed, firefox38 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
STR:
1. Click the search field's magnifying glass icon.
2. The search field's dropdown menu will open.
3. Click the search field's magnifying glass icon a second time.

RESULT:
The dropdown menu will reopen, but it should close (like it used). This bug is probably a regression from the search field's new "magnifying glass with plus symbol" icon.
Sounds potentially related to/caused by bug 1103455.
(Assignee)

Comment 2

4 years ago
Almost certainly yes, should be straightforward to fix though.
Assignee: nobody → dtownsend
Blocks: 1103455
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
(Assignee)

Updated

4 years ago
Iteration: --- → 37.3 - 12 Jan
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 8546884 [details]
MozReview Request: bz://1118135/Mossop
Attachment #8546884 - Flags: review?(felipc)
(Assignee)

Comment 4

4 years ago
/r/2321 - Bug 1118135: Clicking the magnifying glass while the suggestions are open should close the popup and not re-open it.

Pull down this commit:

hg pull review -r 521d024b33011d0f501a5cd6a1317363f585ffed
(Assignee)

Comment 5

4 years ago
One thing I didn't mention in the commit message yet, I moved one of the tests to the end of browser_searchbar_openpopup.js as using synthesizeNativeMouseClick there was somehow causing the following test to timeout on Windows XP debug only. Never figured out why but putting at the end seems to solve the problem for now.
https://reviewboard.mozilla.org/r/2319/#review1517

::: browser/base/content/urlbarBindings.xml
(Diff revision 1)
> +          this._isHiding = false;

Would it work if you used the `popuphidden` event to set `_isHiding` back to false instead of using the setTimeout?
(Assignee)

Comment 7

4 years ago
(In reply to :Felipe Gomes from comment #6)
> https://reviewboard.mozilla.org/r/2319/#review1517
> 
> ::: browser/base/content/urlbarBindings.xml
> (Diff revision 1)
> > +          this._isHiding = false;
> 
> Would it work if you used the `popuphidden` event to set `_isHiding` back to
> false instead of using the setTimeout?

No, popuphidden fires before any of the mouse events make it to the DOM
Attachment #8546884 - Flags: review?(felipc) → review+
(Assignee)

Comment 10

4 years ago
[Tracking Requested - why for this release]: Regression caused by bug 1103455

Not sure who marked 36 as unaffected, both 35 and 36 are affected but we're too late for 35 now.
status-firefox35: --- → affected
status-firefox36: unaffected → affected
tracking-firefox36: --- → ?
(Assignee)

Updated

4 years ago
status-firefox35: affected → wontfix
https://hg.mozilla.org/mozilla-central/rev/036dce7553a1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38

Comment 12

4 years ago
Bug Verification Day-2015-14-01
(Assignee)

Comment 13

4 years ago
Comment on attachment 8546884 [details]
MozReview Request: bz://1118135/Mossop

Approval Request Comment
[Feature/regressing bug #]: bug 1103455
[User impact if declined]: Clicking the magnifying glass just closes then re-opens the search popup
[Describe test coverage new/current, TBPL]: Automated tests running on m-c since landing
[Risks and why]: Low risk, the only in-product piece of this is to ignore click events when certain other events have happened recently. Worst case in some instances clicking the magnifying glass might not open the popup at all but we have automated tests covering the common cases of that.
[String/UUID change made/needed]: None
Attachment #8546884 - Flags: approval-mozilla-beta?
Attachment #8546884 - Flags: approval-mozilla-aurora?
status-firefox38: --- → fixed
tracking-firefox36: ? → +
Attachment #8546884 - Flags: approval-mozilla-beta?
Attachment #8546884 - Flags: approval-mozilla-beta+
Attachment #8546884 - Flags: approval-mozilla-aurora?
Attachment #8546884 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 15

4 years ago
Comment on attachment 8546884 [details]
MozReview Request: bz://1118135/Mossop
Attachment #8546884 - Attachment is obsolete: true
Attachment #8619050 - Flags: review+
(Assignee)

Comment 16

4 years ago
Created attachment 8619050 [details]
MozReview Request: Bug 1118135: Clicking the magnifying glass while the suggestions are open should close the popup and not re-open it.
You need to log in before you can comment on or make changes to this bug.