Closed Bug 1118143 Opened 9 years ago Closed 9 years ago

[Stingray][AppDeck] Newly installed app should display in AppDeck automatically

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][ETA:1/9])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review
Currently, newly installed apps are not display in AppDeck, unless user restart AppDeck.
Blocks: 1074079
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
And recently uninstalled app should be removed from app deck
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/9]
See Also: → 1115633
On second thought, I decide not to implement 'removing uninstalled app from app-deck' here. Because when user uninstall an app, the app must be unpinned first. But currently 'unpin' will take user to Home app (which is incorrect and will be fix in bug 1115633). So I think it is better to implement uninstall app in bug 1115633 or in its follow-up bug.
Attached file pull request
Hi John, 
Would you help to review the patch? 

Removing uninstall app from AppDeck will be fixed in bug 1115633 instead of here, because we need to fix unpin behavior first in bug 1115633.

Thanks
Attachment #8545776 - Flags: review?(im)
Comment on attachment 8545776 [details] [review]
pull request

Looks good to me. Please use a constant instead of a hard-code value.
Attachment #8545776 - Flags: review?(im) → review+
See Also: → 1119639
Filed a bug 1119639 for the same hard-coded value issue in Home app.
Thanks and comment addressed.

Waiting for Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dfa208badc85
landed on master
https://github.com/mozilla-b2g/gaia/commit/ebea563c01c2b19e1be5fca6df2025dc796500de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.