1118143 - [Stingray][AppDeck] Newly installed app should display in AppDeck automatically

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Currently, newly installed apps are not display in AppDeck, unless user restart AppDeck.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

And recently uninstalled app should be removed from app deck

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

On second thought, I decide not to implement 'removing uninstalled app from app-deck' here. Because when user uninstall an app, the app must be unpinned first. But currently 'unpin' will take user to Home app (which is incorrect and will be fix in bug 1115633). So I think it is better to implement uninstall app in bug 1115633 or in its follow-up bug.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi John, 
Would you help to review the patch? 

Removing uninstall app from AppDeck will be fixed in bug 1115633 instead of here, because we need to fix unpin behavior first in bug 1115633.

Thanks

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8545776 [details] [review]
pull request

Looks good to me. Please use a constant instead of a hard-code value.

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Filed a bug 1119639 for the same hard-coded value issue in Home app.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks and comment addressed.

Waiting for Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dfa208badc85

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

rebase to latest master and re-run Gaia-Try
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9930dcd4dcf6

Comment 8

[Tzu-Lin Huang [:dwi2][:tzhuang]]

landed on master
https://github.com/mozilla-b2g/gaia/commit/ebea563c01c2b19e1be5fca6df2025dc796500de