[Stingray][AppDeck] Newly installed app should display in AppDeck automatically

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices][ETA:1/9])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently, newly installed apps are not display in AppDeck, unless user restart AppDeck.
(Assignee)

Updated

3 years ago
Blocks: 1074079
(Assignee)

Updated

3 years ago
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
And recently uninstalled app should be removed from app deck
(Assignee)

Updated

3 years ago
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/9]
(Assignee)

Updated

3 years ago
See Also: → bug 1115633
(Assignee)

Comment 2

3 years ago
On second thought, I decide not to implement 'removing uninstalled app from app-deck' here. Because when user uninstall an app, the app must be unpinned first. But currently 'unpin' will take user to Home app (which is incorrect and will be fix in bug 1115633). So I think it is better to implement uninstall app in bug 1115633 or in its follow-up bug.
(Assignee)

Comment 3

3 years ago
Created attachment 8545776 [details] [review]
pull request

Hi John, 
Would you help to review the patch? 

Removing uninstall app from AppDeck will be fixed in bug 1115633 instead of here, because we need to fix unpin behavior first in bug 1115633.

Thanks
Attachment #8545776 - Flags: review?(im)
Comment on attachment 8545776 [details] [review]
pull request

Looks good to me. Please use a constant instead of a hard-code value.
Attachment #8545776 - Flags: review?(im) → review+
(Assignee)

Updated

3 years ago
See Also: → bug 1119639
(Assignee)

Comment 5

3 years ago
Filed a bug 1119639 for the same hard-coded value issue in Home app.
(Assignee)

Comment 6

3 years ago
Thanks and comment addressed.

Waiting for Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dfa208badc85
(Assignee)

Comment 7

3 years ago
rebase to latest master and re-run Gaia-Try
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9930dcd4dcf6
(Assignee)

Comment 8

3 years ago
landed on master
https://github.com/mozilla-b2g/gaia/commit/ebea563c01c2b19e1be5fca6df2025dc796500de
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.