1118189 - [Flame][Settings]There is no space between "Change homescreen" and "Change" button.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sue]

[1.Description]:
[Flame v2.2][Settings]The "Change homescreen" and "Change" button are next to each other without any space.
Found time:14:58
See attachment:screenshot.png and logcat_1458.txt

[2.Testing Steps]: 
1. Launch Settings -> Homescreens.
2. Tap "Homescreen".

[3.Expected Result]: 
2. There should be a space between "Change homescreen" and "Change" button.

[4.Actual Result]: 
2. There is no space between "Change homescreen" and "Change" button.

[5.Reproduction build]: 
Gaia-Rev        4ceeff19086b2a2955f044ad923dcfa63a293de3
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/912036eeb024
Build-ID        20150105160215
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150105.192724
FW-Date         Mon Jan  5 19:27:36 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]:
Free Test

Comment 1

[Sue]

Attachment: logcat_1458.txt

Comment 2

[Sue]

Attachment: screenshot.png

Comment 3

[Eric Chang [:ericcc] [:echang]]

Hi EJ, Could you hwlp with this?
Is the a WIP? The Gaia Homescreen also looks weird.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Helen, can you give us some ideas (or spec) from visual side ? Thanks :)

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Kevin,

I just checked from codebase and noticed something interesting. The reason why this menuItem would be shown is because we installed two Homescreen apps (one is "verticalhome" while another one is "homescreen").

The most interesting stuff is that, from 2.1, we have definitely installed two apps in our phones already, 
but not sure why `navigator.mozApps.mgmt.getAll()` would only return one homescreen app instead of two homescreen apps.

While for recent 2.2, `navigator.mozApps.mgmt.getAll()` would return these two homescreen apps and in this way, the menuItem got shown in Settings app. And also, if you click on the old homescreen icon in that menuItem, the whole homescreen would be broken with no apps and the only thing you can do is restore it back to vertical homescreen.

Because you are more familiar with homescreen, can you give us (+UX, Visual) some advices whether this special menuItem to change homescreens should be used or not ?

Thanks :)

Comment 6

[Kevin Grandon :kgrandon]

We never did UX for this screen. The screen is not present in production builds because we do not ship both home screens. It's on the list of things to resolve, but I wouldn't worry about it for now.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

If we don't support multiple homescreens for production, should we still need this panel ? For me, not only I can't change to old homescreen by clicking on the button (not sure what's the prerequisite for this), but also the UI looks weird to us and QA may keep reporting bugs like this.

I got some ideas here, because I assume in the future, we can make users do download different homescreens if the want, this menu is still in need for that case. For now, we can keep this bug as open/backlog and let UX/Visual to propose how to integrate these two similar menuItems (this is what they want to do for now after asking Helen & Jenny)

And if QA reported any similar bug like this recently, we would keep marking them as duplicate of this one.

Hope this make sense to you all :)

Comment 8

[Kevin Grandon :kgrandon]

Yes, replaceable home screens are coming, and we will need to do some UX work on these panels. QA should probably be testing on production builds, and not engineering builds, it's closer to what a user sees.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Kevin, you are right, QA may not realize this part and I think they should know this about what we did here for different builds.

@Sue, please see our comment from 5 ~ 9 and help us pass this message to related QA who focuses on this part too. thanks !

@Helen, please help to provide spec with Jenny here (this would be under backlog, so the priority would be lower), thanks !

Comment 10

[Sue]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #9)
> @Kevin, you are right, QA may not realize this part and I think they should
> know this about what we did here for different builds.
> 
> @Sue, please see our comment from 5 ~ 9 and help us pass this message to
> related QA who focuses on this part too. thanks !
> 
> @Helen, please help to provide spec with Jenny here (this would be under
> backlog, so the priority would be lower), thanks !

Thanks for your help. I will pass this message to our members.

Comment 11

[Helen Huang [:HHuang]]

Looks like we need some ux support here, I'm going to need info Francis who is the ux designer for Homescreen in Settings.

Hi Francis, can you take a look of this bug? Seems we're supporting multiple homescreens in the latest build, and it shows two Homescreens in Settings for now. Could you help to propose how to integrate those two menuItems? If any visual needs, please let me know. Thanks!

Comment 12

[Francis Djabri [:djabber]]

(In reply to Helen Huang from comment #11)
> Looks like we need some ux support here, I'm going to need info Francis who
> is the ux designer for Homescreen in Settings.

Katie C is the homescreen UX owner, so passing over to her. Katie, please could you check out this bug. Thanks!

Comment 13

[Kevin Grandon :kgrandon]

This should probably be handled by whoever would normally handle settings UX, as the changes belong in the settings app.

Comment 14

[katieC]

There is no UX spec for updating Homescreen Settings for 2.2. So, homescreen settings should only be offering the 3 icon or 4 icon layout as a user choice (as it was before)... this is a bug and Homescreen Settings should be reverted to the way it was previously.

Comment 15

[BMO Automation]

Firefox OS is not being worked on