Closed Bug 1118246 Opened 5 years ago Closed 5 years ago

Issues on the standalone page after deleting the active conversation

Categories

(Hello (Loop) :: Client, defect, P2)

x86_64
Windows 7
defect
Points:
2

Tracking

(firefox37 verified)

VERIFIED FIXED
mozilla37
Iteration:
37.3 - 12 Jan
Tracking Status
firefox37 --- verified
Blocking Flags:
backlog Fx37+

People

(Reporter: pauly, Assigned: standard8)

References

Details

Attachments

(2 files)

STR:
1. Start latest nightly
2. Disable e10s (otherwise won't be able to make a 1:1 call on the same machine - bug 1109062)
3. Create a new room
4. Copy/paste the URL in Nightly or Chrome and join the call
5. While the call is active, delete the room from the Hello panel

Actual results:
'Leave' button still active, no error message explaining what's happening (ie: the conversation is no longer available), a small rectangle on the bottom right corner.
Browser console logs:
"Rumor.Socket: Rumor Socket Disconnected: Used to indicate that a connection was closed abnormally (that is, with no close frame being sent) when a status code is expected. (CLOSE_ABNORMAL)" sdk.js:910:14

"OT.Raptor.Socket: cannot publish until the socket is connected.{"method":"delete","uri":"/v2/partner/44835892/session/1_MX40NDgzNTg5Mn5-MTQyMDU1NDI2NTczNX56bDNJN0ZXTitSRi9BWTdobmZSVEtjWU1-UH4/stream/58557c49-38a3-414d-b193-3f21c19275b2","content":{}}" sdk.js:910:14

no element found ClientEvent:1:1
"Loop hawkRequest error:" Object { code: 404, errno: 105, error: "Token not found." } MozLoopService.jsm:547
Object { code: 404, errno: 105, error: "Token not found." } LoopRooms.jsm:429
Also note https://bugzilla.mozilla.org/show_bug.cgi?id=1092954#c32
"NOTE also: if the room is deleted while the standalone user is in the room (but the desktop user is not), nothing appears to happen on the standalone side."
(In reply to Paul Silaghi, QA [:pauly] from comment #2)
> Also note https://bugzilla.mozilla.org/show_bug.cgi?id=1092954#c32
> "NOTE also: if the room is deleted while the standalone user is in the room
> (but the desktop user is not), nothing appears to happen on the standalone
> side."

Yep, we can't do much about that, as there's no easy route for us to do anything here. What will most likely happen is that after approximately 5 minutes, the user will get booted out with information about the link being expired or invalid.

I have a fix in progress for comment 0.
Assignee: nobody → standard8
Iteration: --- → 37.3 - 12 Jan
Points: --- → 2
This gets it working properly. When I originally wrote the sdk driver, I think I wasn't really expecting events with reason forceDisconnected, or if I was, I was expecting them as part of the connectionDestroyed event.

Re-reading the sdk docs, its clear that for the client which is disconnected, the event which happens is sessionDisconnected with reason forceDisconnected - hence this patch adds the extra dispatch. I treat it as an expired/invalid url, as effectively that's what it has become.
Attachment #8544606 - Flags: review?(nperriault)
Comment on attachment 8544606 [details] [diff] [review]
Loop should handle forceDisconnect events from the OT sdk.

Review of attachment 8544606 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8544606 - Flags: review?(nperriault) → review+
backlog: --- → Fx37+
Priority: -- → P2
https://hg.mozilla.org/integration/fx-team/rev/6d5a48fde5fb
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/6d5a48fde5fb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Mark Banner (:standard8) from comment #3)
> What will most likely happen is that after approximately 5
> minutes, the user will get booted out with information about the link being
> expired or invalid.
The call is still active after 10 min. Probably the same server refresh issue as in bug 1123349.

> I have a fix in progress for comment 0.
Verified fixed 37.0a2 (2015-01-19) Win 7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.