Closed Bug 1118279 Opened 5 years ago Closed 5 years ago

Intermittent e10s browser_customize_popupNotification.js | Test timed out

Categories

(Firefox :: General, defect)

x86
Windows 7
defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 38
Iteration:
38.2 - 9 Feb
Tracking Status
e10s + ---
firefox36 --- unaffected
firefox37 --- wontfix
firefox38 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

21:14:11 INFO - 303 INFO TEST-START | browser/base/content/test/general/browser_customize_popupNotification.js
21:14:11 INFO - JavaScript error: chrome://global/content/browser-child.js, line 450: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]
21:14:11 INFO - JavaScript error: chrome://global/content/browser-child.js, line 450: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]
21:14:11 INFO - JavaScript error: chrome://global/content/browser-child.js, line 450: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]
21:14:11 INFO - -*-*- UserCustomizations (child): document created: about:home
21:14:11 INFO - -*-*- UserCustomizations (child): _injectInWindow
21:14:11 INFO - -*-*- UserCustomizations (child): principal status: 0
21:14:11 INFO - JavaScript error: chrome://browser/content/abouthome/aboutHome.js, line 258: NotFoundError: The operation failed because the requested database object could not be found. For example, an object store did not exist but was being opened.
21:14:56 INFO - TEST-INFO | screenshot: exit status 0
21:14:56 INFO - 304 INFO checking window state
21:14:56 INFO - 305 INFO Console message: [JavaScript Error: "gProxyFavIcon is null" {file: "chrome://browser/content/browser.js" line: 11770}]
21:14:56 INFO - 306 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]" {file: "chrome://global/content/browser-child.js" line: 450}]
21:14:56 INFO - 307 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]" {file: "chrome://global/content/browser-child.js" line: 450}]
21:14:56 INFO - 308 INFO Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessageSender.sendAsyncMessage]" {file: "chrome://global/content/browser-child.js" line: 450}]
21:14:56 INFO - 309 INFO Console message: [JavaScript Error: "NotFoundError: The operation failed because the requested database object could not be found. For example, an object store did not exist but was being opened." {file: "chrome://browser/content/abouthome/aboutHome.js" line: 258}]
21:14:56 INFO - 310 INFO Console message: 1420521272935 Services.HealthReport.HealthReporter WARN Recording new remote ID: 23233442-f724-404c-89b0-c177e2527522
21:14:56 INFO - 311 INFO Console message: 1420521272947 Services.DataReporting.Policy WARN Hard error submitting data: Server failure.
21:14:56 INFO - 312 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_customize_popupNotification.js | Test timed out - expected PASS
21:14:56 INFO - 313 INFO MEMORY STAT vsize after test: 742842368
21:14:56 INFO - 314 INFO MEMORY STAT vsizeMaxContiguous after test: 588185600
21:14:56 INFO - 315 INFO MEMORY STAT residentFast after test: 293126144
21:14:56 INFO - 316 INFO MEMORY STAT heapAllocated after test: 75048462
21:14:56 INFO - 317 INFO TEST-OK | browser/base/content/test/general/browser_customize_popupNotification.js | took 45030ms
Summary: Intermittent browser_customize_popupNotification.js | Test timed out → Intermittent e10s browser_customize_popupNotification.js | Test timed out
Blocks: e10s-tests
tracking-e10s: --- → +
Gavin, this is currently the #2 failure on OrangeFactor. Can you please help find an owner for this? :)
Flags: needinfo?(gavin.sharp)
Flags: needinfo?(gavin.sharp) → needinfo?(ttaubert)
Flags: needinfo?(dtownsend)
Fixing the failure itself is quite easy, we just need to wait for the initial tab to load. The tab load itself seems to hide the popup notification right after it was opened and makes us time out.

The other problem here is the |gURLBar.remove()| call. That leads to leaks:

52 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_customize_popupNotification.js | leaked until shutdown [nsGlobalWindow #17 inner chrome://browser/content/browser.xul about:blank] - expected PASS
53 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_customize_popupNotification.js | leaked until shutdown [nsGlobalWindow #16 outer  about:blank] - expected PASS
Flags: needinfo?(ttaubert)
(In reply to Tim Taubert [:ttaubert] from comment #202)
> The other problem here is the |gURLBar.remove()| call. That leads to leaks:

Doesn't leak when removing the whole navigation toolbar, great.
Feel free to redirect but I thought you might be a good choice given that you wrote the test :)
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8560018 - Flags: review?(gavin.sharp)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a9bf36a45d2
Iteration: --- → 38.2 - 9 Feb
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8560018 [details] [diff] [review]
0001-Bug-1118279-Fix-intermittent-browser_customize_popup.patch

Review of attachment 8560018 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_customize_popupNotification.js
@@ +26,5 @@
> +
> +  yield promiseWindowClosed(win);
> +});
> +
> +function promiseBrowserLoaded(browser) {

The test comes with its own implementation because the one in head.js skips about:blank events, meh.
Comment on attachment 8560018 [details] [diff] [review]
0001-Bug-1118279-Fix-intermittent-browser_customize_popup.patch

>diff --git a/browser/base/content/test/general/browser_customize_popupNotification.js b/browser/base/content/test/general/browser_customize_popupNotification.js

>+    ok(notification, "showed the notification");
>+    yield panelPromise;

Changing the order of these compared to the old code means we should probably change that test description to be "show() succeeded" instead of "showed the notification".
Flags: needinfo?(dtownsend)
Attachment #8560018 - Flags: review?(gavin.sharp) → review+
(In reply to Tim Taubert [:ttaubert] from comment #205)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a9bf36a45d2

Retriggered the PGO try runs a few times and saw no failures.
Had to back out:

https://hg.mozilla.org/integration/fx-team/rev/7099b4cceabb

TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_customize_popupNotification.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_customize_popupNotification.js | leaked 1 window(s) until shutdown [url = about:blank]

Seems to leak only in debug builds... which I didn't run on try because the test failed only with PGO before :/
I was trying to find a good way to remove nav bar or hide the location bar without leaking or destroying everything. As it turns out we don't support doing that anymore since we landed Australis. We can just pick the easy way out and remove the test, there is no value in having that option covered anymore.
Attachment #8560018 - Attachment is obsolete: true
Attachment #8560548 - Flags: review?(gavin.sharp)
Attachment #8560548 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/966cd36a361a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Not going to bother uplifting to Aurora since e10s is disabled there I don't see any other non-e10s flakiness in this test that affects it.
You need to log in before you can comment on or make changes to this bug.