1118292 - Wrong app name is displayed in the Reviewer Tools - Apps queue

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Madalin Cotetiu]

Attachment: testLocales.zip

Steps to reproduce:
1. Create a new packaged app  and in the manifest make sure to have the following fields:
 "name": "SomeRandomName", 
 "default_locale": "en", 
 "locales": {
    "es": {
      "name": "esLocaleName", 
      "description": "test"
    }
  }, 

2. Submit the packaged app.
3. Open reviewer tools Queues-Apps: https://marketplace.allizom.org/reviewers/apps/queue/?sort=nomination&order=desc
4. Observe the submitted app name.

Expected results:
The correct app name is displayed (the one from the "name" field, in this case "name": "SomeRandomName")

Actual results:
The displayed name is the one from "locales" section. (in this case "name": "esLocaleName", ). After clicking the app name and opening the app review detail page the correct name is displayed.

Notes/Issues:
Verified in FF37(Win7) this issue can be reproduced in mp-stage.
Screencast for this issue: http://screencast.com/t/qxxsMdofY
Attaching the used packaged app.

Comment 1

[Rob Hudson [:robhudson]]

Great find. This is probably because of the waffle switch that enables reviewer tools with the elasticsearch backend. ES stores the localized app names in a few ways to do sorting and other queries so there's likely something amiss in the logic to display the app name. I'll look into it soon.

In the meantime if you're worried you could disable the waffle switch ("reviewer-tools-elasticsearch") on stage and verify there is no problem with the waffle switch off.

Comment 2

[Madalin Cotetiu]

You are right Rob, the issue appears to be related to ES. After disabling the waffle search on stage the correct name is displayed: http://screencast.com/t/NZ3cw3E3