Closed Bug 1118299 Opened 6 years ago Closed 6 years ago

The new perf tool doesn't work anymore: TypeError: invalid 'in' operand this._blueprint

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: vporof, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
This happens after finishing a recording.
Bug 1087877 is the culprit.
Flags: needinfo?(paul)
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Thanks Jordan.
Flags: needinfo?(paul)
Looks like we'll need to implement filtering for perf++ too for this.
Attached patch 1118299-blueprint-default.patch (obsolete) — Splinter Review
Just a patch to get perf++ working again.
 https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=021de5f5d477
Attachment #8545448 - Flags: review?(vporof)
Created bug 1119023 to filter out markers in perf++
Comment on attachment 8545448 [details] [diff] [review]
1118299-blueprint-default.patch

Review of attachment 8545448 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/timeline/widgets/markers-overview.js
@@ +19,5 @@
>  
>  loader.lazyRequireGetter(this, "L10N",
>    "devtools/timeline/global", true);
> +loader.lazyRequireGetter(this, "TIMELINE_BLUEPRINT",
> +  "devtools/timeline/global", true);

Instead of importing this here, set the blueprint (as expected by this module) when constructing the MarkersOverview in overview.js in the new perf tool.
Attachment #8545448 - Flags: review?(vporof) → review-
Waterfall and MarkerOverview consumers now pass in the default blueprint

 https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5aea2a2426b9
Attachment #8545448 - Attachment is obsolete: true
Attachment #8546080 - Flags: review?(vporof)
Comment on attachment 8546080 [details] [diff] [review]
1118299-blueprint-default.patch

Review of attachment 8546080 [details] [diff] [review]:
-----------------------------------------------------------------

Noice
Attachment #8546080 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/72ee3f94b5f8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.