Closed Bug 1118303 Opened 9 years ago Closed 8 years ago

Create a store to set loop preferences

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: rgauthier, Unassigned)

Details

As mentionned in Bug 1113613, we may want to investigate using a store to set loop preferences.

For now it sounds overkill, but if we tend to change preferences more and more in the views, a store may be cleaner.
Dan: is this still valid?
Flags: needinfo?(dmose)
I'm sure we talked about this a while ago and I was meant to close it...

The reasoning being:

- For the debug.* preferences, we should just simplify things and make it controlled by only one preference (bug 1118842).
- For the rest of the preferences, they are obtained via the loop-api and I think are generally passing in in reasonable places. I don't think it warrants the additional overhead of a store to manage these.

We might need to watch if we're managing preferences in views too much, and need to move the preference handling into stores, but those stores should really be associated with the appropriate views.

Hence, I think this is a wontfix, with a "watch how we're doing things moving forward".
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dmose)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.