Closed Bug 1118331 Opened 7 years ago Closed 5 years ago
Miss call notification sometimes appears twice test
_dialer _clear _miss _call _notification .py
Discovered in this adhoc job. Sometimes test_dialer_clear_miss_call_notification.py gets 2 missed call notifications instead of 1. This requires further investigation. TEST-START | test_dialer_clear_miss_call_notification.py TestDialerClearMissCallNotification.test_dialer_clear_miss_call_notification TEST-UNEXPECTED-FAIL | test_dialer_clear_miss_call_notification.py TestDialerClearMissCallNotification.test_dialer_clear_miss_call_notification | AssertionError: 3 != 2 Traceback (most recent call last): File "/var/jenkins/2/workspace/flame-kk.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_client-0.8.6-py2.7.egg/marionette/marionette_test.py", line 268, in run testMethod() File "/var/jenkins/2/workspace/flame-kk.ui.adhoc/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer_clear_miss_call_notification.py", line 76, in test_dialer_clear_miss_call_notification self.assertEqual(len(notifications), 2)  http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/545/
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s8][fxosqa-auto-points=4]
On the screenshot of the HTML report, we can clearly see 2 missed call notification instead of 1. I took a look at the logcat at the time of the 66th repeat (between 08:15:50 and 08:17:15, device time) and I didn't see 2 calls incoming. Another thing, the tests took the same time to run when it was failing than when it's passing. Gabriele, do you think it's possible we hit a race condition with the dialer/notification code here? If not, feel free to move this bug back to Gaia::UI Tests.  http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/545/HTML_Report/  /!\ it weights 58.58MB http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/545/artifact/tests/python/gaia-ui-tests/logcat.txt  http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/545/console
QA Whiteboard: [fxosqa-auto-s8][fxosqa-auto-points=4] → [fxosqa-auto-dropped-s8]
Component: Gaia::UI Tests → Gaia::Dialer
Summary: Investigate test_dialer_clear_miss_call_notification.py → Miss call notification sometimes appears twice test_dialer_clear_miss_call_notification.py
This is mighty strange, as in theory we send a notification only in response to a 'telephony-call-ended' event and I don't see how it would be possible for us to send two of them in response to a single call. If somehow we received two 'telephony-call-ended' events it would be possible but that would indicate that there's a bug somewhere in Gecko or the RIL.
Does comment 2 sounds probable to you Hsin-Yi?
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #3) > Does comment 2 sounds probable to you Hsin-Yi? Hi Johan, In theory, in RIL we send a notification per a disconnected call. I couldn't get an obvious idea about which line in Gecko is suspicious and need to investigate. If you could get more debugging messages, that would help me a lot. For this bug, please enable the debugger for both RIL and system message components. 1) For RIL, please do: 1. adb pull /system/b2g/defaults/pref/user.js . < edit user.js and set "ril.debugging.enabled" to true > 2. adb remount 3. adb push user.js /system/b2g/defaults/pref 4. adb shell sync && adb reboot 2) For system message components, you could do either a) or b). Note b) is supposed to work but I didn't really try. a)Un-comment the line , and rebuild. b) 1. adb root adb remount 2. Pull omni.ja from DUT adb pull /system/b2g/omni.ja 3. Unzip omni.ja unzip omni.ja -d Omni 4. Find SystemMessageInternal.js in Omni/components/ 5. Open SystemMessageInternal.js and un-comment the line  6. cd Omni, zip all files zip -r omni.ja * 7. Push it back to DUT then reboot it. adb push omni.ja /system/b2g adb reboot  https://dxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js?from=systemmessageinternal.js#53
Let me clear NI first. Feel free to pin me if you get debug messages later, thank you.
These tests are not run anymore.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.