Closed
Bug 1118335
Opened 9 years ago
Closed 8 years ago
Create React oriented test helpers for Loop
Categories
(Hello (Loop) :: Client, defect, P5)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
WONTFIX
backlog | tech-debt |
People
(Reporter: NiKo, Unassigned)
Details
(Whiteboard: [tech-debt])
Things we should have helpers for: // render a component into a fake document var view = TestUtils.renderIntoDocument( React.createElement(loop.conversationViews.IncomingCallView, { model: model, video: false })); // testing component type sinon.assert.calledWith(React.render, sinon.match(function(value) { return TestUtils.isCompositeComponentElement(value, loop.panel.PanelView); })); And so on.
Reporter | ||
Updated•9 years ago
|
Whiteboard: tech-debt
Updated•9 years ago
|
backlog: --- → tech-debt
Priority: -- → P5
Updated•9 years ago
|
Rank: 55
Updated•9 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: tech-debt → [tech-debt]
Comment 1•8 years ago
|
||
We're still using the first form here, though we frequently wrap it into a function as the views are often used more than once. It hasn't caused us a lot of pain to not have the wrapper, and the second form has gone away. So I think I'm just going to wontfix this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•