Create React oriented test helpers for Loop

RESOLVED WONTFIX

Status

Hello (Loop)
Client
P5
normal
Rank:
55
RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: NiKo, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tech-debt])

Things we should have helpers for:

// render a component into a fake document
var view = TestUtils.renderIntoDocument(
  React.createElement(loop.conversationViews.IncomingCallView, {
    model: model,
    video: false
}));


// testing component type
sinon.assert.calledWith(React.render,
  sinon.match(function(value) {
    return TestUtils.isCompositeComponentElement(value, loop.panel.PanelView);
  }));

And so on.
Whiteboard: tech-debt

Updated

3 years ago
backlog: --- → tech-debt
Priority: -- → P5

Updated

2 years ago
Rank: 55
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: tech-debt → [tech-debt]
We're still using the first form here, though we frequently wrap it into a function as the views are often used more than once.

It hasn't caused us a lot of pain to not have the wrapper, and the second form has gone away. So I think I'm just going to wontfix this.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.