Treeherder deals poorly with an empty bug suggestion field

VERIFIED FIXED

Status

Tree Management
Treeherder
P4
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This isn't a new issue, but I hit it more frequently now that we have the 'c' and 'r' keyboard shortcuts for me to mix up :P

Basically, once you pull up the bug suggestion textbox, TH treats whatever goes into there as a bug number in need of submission even if it's left empty. For example, if I hit 'r' when I meant to hit 'c' to add a comment for a backout, I now need to hit enter to unfocus that textbox and then manually delete the empty bug suggestion. Otherwise, TH will error when I submit the classification.

If the box is empty, it should just be ignored.
(Assignee)

Comment 1

3 years ago
Makes sense - I noticed it before also. I'll have a look at it.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Priority: -- → P4
(Assignee)

Comment 2

3 years ago
Created attachment 8545377 [details] [review]
treeherder-ui-PR#330

Please see above PR for status and review.
Attachment #8545377 - Flags: review?(cdawson)

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/2ea180ac05592ff80247887771df2b05fb3e8eb3
Bug 1118345 - Ignore empty related bug input fields on entry

https://github.com/mozilla/treeherder-ui/commit/017788753495b086abb68a3b51749a3b5ad8412a
Merge pull request #330 from tojonmz/ignore-empty-bug

Bug 1118345 - Ignore empty related bug input fields on entry

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

3 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED

Updated

3 years ago
Attachment #8545377 - Flags: review?(cdawson) → review+

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e52d913366c8973bfc00b5b8a891604599b1d845
Bug 1118345 - Ignore empty related bug input fields on entry

https://github.com/mozilla/treeherder/commit/a1835249ed3e9cbb3c1875acc552adaaab2fa926
Merge pull request #330 from tojonmz/ignore-empty-bug

Bug 1118345 - Ignore empty related bug input fields on entry
You need to log in before you can comment on or make changes to this bug.