1118345 - Treeherder deals poorly with an empty bug suggestion field

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ryan VanderMeulen [:RyanVM]]

This isn't a new issue, but I hit it more frequently now that we have the 'c' and 'r' keyboard shortcuts for me to mix up :P

Basically, once you pull up the bug suggestion textbox, TH treats whatever goes into there as a bug number in need of submission even if it's left empty. For example, if I hit 'r' when I meant to hit 'c' to add a comment for a backout, I now need to hit enter to unfocus that textbox and then manually delete the empty bug suggestion. Otherwise, TH will error when I submit the classification.

If the box is empty, it should just be ignored.

Comment 1

[Jonathan French (:jfrench)]

Makes sense - I noticed it before also. I'll have a look at it.

Comment 2

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#330

Please see above PR for status and review.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/2ea180ac05592ff80247887771df2b05fb3e8eb3
Bug 1118345 - Ignore empty related bug input fields on entry

https://github.com/mozilla/treeherder-ui/commit/017788753495b086abb68a3b51749a3b5ad8412a
Merge pull request #330 from tojonmz/ignore-empty-bug

Bug 1118345 - Ignore empty related bug input fields on entry

Comment 4

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e52d913366c8973bfc00b5b8a891604599b1d845
Bug 1118345 - Ignore empty related bug input fields on entry

https://github.com/mozilla/treeherder/commit/a1835249ed3e9cbb3c1875acc552adaaab2fa926
Merge pull request #330 from tojonmz/ignore-empty-bug

Bug 1118345 - Ignore empty related bug input fields on entry