Closed Bug 1118381 Opened 5 years ago Closed 5 years ago

js::DebuggerMemory::drainAllocationsLog's dance around the incremental GC is obscure

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox37 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

(Whiteboard: [adv-main37-])

Attachments

(1 file)

[Flagging as JS s-s because the original was as well.]

The patch in bug 1116303 is extremely obscure, and needs to be commented if it's not to be broken again by future work.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8544730 - Flags: review?(sphink)
Comment on attachment 8544730 [details] [diff] [review]
Carefully explain our dance around the incremental GC when draining the Debugger's allocations log.

Comment changes don't need r+, but terrence okay'ed this anyway.
Attachment #8544730 - Flags: review?(sphink) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4933f14465f2
Flags: in-testsuite-
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/4933f14465f2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Group: javascript-core-security → core-security
Whiteboard: [adv-main37-]
Group: core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.