1118393 - Can not use {{num}} in rooms_list_current_conversations in loop.properties

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Alexander L. Slovesnik]

Attachment: Screenshot of bug

STR:
1) Download and install Russian build of Firefox 35.0 beta (which uses {{num}} in rooms_list_current_conversations, see http://hg.mozilla.org/releases/l10n/mozilla-beta/ru/file/ee50c25837e3/browser/chrome/browser/loop/loop.properties#l129 ) from https://www.mozilla.org/en-US/firefox/beta/all/
2) Click on Hello icon to open conversation.

Expected result:
Loop client windows shows: 1 активный звонок (1 Current conversation)

Actual result:
Loop client windows shows: {{num}} активный звонок ({{num}} Current conversation)
See attached screenshot.

Comment 1

[Francesco Lodolo [:flod]]

Link to the reference string that says "you can use {{num}}"
http://hg.mozilla.org/releases/mozilla-beta/file/default/browser/locales/en-US/chrome/browser/loop/loop.properties#l307

We have at least another locale using that (gd).

Comment 2

[Maire Reavy [:mreavy]]

Mark -- What's the best way to fix this?

Comment 3

[Michael Bauer]

Yes, we use {{num}} because ONE in gd covers both 1 and 11.

Comment 4

[Mark Banner (:standard8)]

Attachment: Cannot use {{num}} in rooms_list_current_conversations - Don't remove the num argument for plural forms, as its a valid possible value.

Jared: This fixes the issue and lets us use num as a replacable value in the string. Do you recall if there was a reason you deleted num from the arguments?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8547770 [details] [diff] [review]
Cannot use {{num}} in rooms_list_current_conversations - Don't remove the num argument for plural forms, as its a valid possible value.

Review of attachment 8547770 [details] [diff] [review]:
-----------------------------------------------------------------

Ah! Good debugging. I removed it because it didn't look like it was being used outside of just determining if the plural form should be used. Obviously I was wrong. Can we include a test here to make sure people like me don't make the same mistake again in the future?

Comment 6

[Mark Banner (:standard8)]

Attachment: Cannot use {{num}} in rooms_list_current_conversations - Don't remove the num argument for plural forms, as its a valid possible value.

Updated patch to include unit tests.

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/31f70be9d69a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/31f70be9d69a

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8555251 [details] [diff] [review]
Cannot use {{num}} in rooms_list_current_conversations - Don't remove the num argument for plural forms, as its a valid possible value.

Approval Request Comment
[Feature/regressing bug #]: Hello rooms / 1074672
[User impact if declined]: For a couple of locales, the number of conversations won't be translated and will show as "{{num}} активный звонок" - this is in the primary panel UI.
[Describe test coverage new/current, TreeHerder]: Includes a unit test, landed in m-c.
[Risks and why]: Low - simple change; includes test coverage.
[String/UUID change made/needed]: None

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca5b3a9640ba
https://hg.mozilla.org/releases/mozilla-beta/rev/fac8edb83df7