Mark virtual overridden functions as MOZ_OVERRIDE in places; r=mak

RESOLVED FIXED in mozilla38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1117034
(Assignee)

Comment 1

4 years ago
Created attachment 8553313 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in places
Attachment #8553313 - Flags: review?(mak77)
Comment on attachment 8553313 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in places

Review of attachment 8553313 [details] [diff] [review]:
-----------------------------------------------------------------

wow, this sounds like a huge effort, especially when it has to be applied to classes just derived from interfaces.
Attachment #8553313 - Flags: review?(mak77) → review+
(Assignee)

Comment 3

4 years ago
The good news is that if you use the NS_DECL_... macros generated by the XPIDL compiler, it will take care of it for you!
https://hg.mozilla.org/mozilla-central/rev/fdefac62cd56
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.