Closed Bug 1118413 Opened 6 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in places; r=mak

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8553313 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in places

Review of attachment 8553313 [details] [diff] [review]:
-----------------------------------------------------------------

wow, this sounds like a huge effort, especially when it has to be applied to classes just derived from interfaces.
Attachment #8553313 - Flags: review?(mak77) → review+
The good news is that if you use the NS_DECL_... macros generated by the XPIDL compiler, it will take care of it for you!
https://hg.mozilla.org/mozilla-central/rev/fdefac62cd56
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.