Closed Bug 1118419 Opened 9 years ago Closed 9 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in graphics; r=jrmuizel

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Mark virtual overridden functions as MOZ_OVERRIDE in graphics
93.37 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
Attachment #8544782 - Flags: review?(jmuizelaar)
Attachment #8544782 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/c8bed3614b4e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8544782 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in graphics

>diff --git a/gfx/gl/GLContextCGL.h b/gfx/gl/GLContextCGL.h
> class GLContextCGL : public GLContext
> {
[...]
> public:
>-    MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(GLContextCGL)
>+    MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(GLContextCGL, MOZ_OVERRIDE)
                                                          ^^^^^^^^^^^^^^
We need this exact same fix in GLContextGLX and GLContextWGL (the two remaining GLContext subclasses that lack this annotation).

I just pushed this same tweak to those classes, as a followup commit for this bug:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/42755ce4d13f
You need to log in before you can comment on or make changes to this bug.