1118419 - Mark virtual overridden functions as MOZ_OVERRIDE in graphics; r=jrmuizel

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[(no longer active)]

Attachment: Mark virtual overridden functions as MOZ_OVERRIDE in graphics

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c8bed3614b4e

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8544782 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in graphics

>diff --git a/gfx/gl/GLContextCGL.h b/gfx/gl/GLContextCGL.h
> class GLContextCGL : public GLContext
> {
[...]
> public:
>-    MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(GLContextCGL)
>+    MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(GLContextCGL, MOZ_OVERRIDE)
                                                          ^^^^^^^^^^^^^^
We need this exact same fix in GLContextGLX and GLContextWGL (the two remaining GLContext subclasses that lack this annotation).

I just pushed this same tweak to those classes, as a followup commit for this bug:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/42755ce4d13f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42755ce4d13f